-
Notifications
You must be signed in to change notification settings - Fork 673
replace random nonces with message sequence numbers #617
Conversation
I did some benchmarking of this today. Running I also ran |
Ok, I'm going to add a few specific comments about the current |
Not quite. We have the following in the
|
Almost all fixed in the above commit. I will squash that, but figured it would be better to have it around temporarily so it's obvious what i've changed. Good call on the naming and dispatching on the delta. And good catch on the overflow. Re Re ordering... I thought about this a fair bit when I wrote the code and experimented with a few variations. In the end I settled on the current version because the |
Yes. But why can't that be turned into |
ah true. Just realised that myself :) |
Since TCP is reliable, we do not need to transmit the nonce itself; the recipient can simply construct the nonce from its own message counter. Hence there is no message envelope and we can thus remove a whole layer of encoding.
we only needed it because of the nonce channels
replace random nonces with message sequence numbers Fixes #564.
Fixes #564.