Skip to content
This repository has been archived by the owner on Jun 20, 2024. It is now read-only.

Fixes post #612 #642

Merged
merged 2 commits into from
May 11, 2015
Merged

Conversation

errordeveloper
Copy link
Contributor

Use rsync instead of cp to avoid uploading site to a subdirectory (when the directory already exists).

@errordeveloper errordeveloper changed the title No redirect required for latest_release_doc_updates Fixes post 612 May 8, 2015
@errordeveloper errordeveloper changed the title Fixes post 612 Fixes post #612 May 8, 2015
@errordeveloper
Copy link
Contributor Author

The switch to gsutil rsync is mostly due to GoogleCloudPlatform/gsutil#274, but also it's somewhat more optimal anyway.

@@ -22,11 +22,11 @@ export BRANCH COMMIT OUTPUT
bundle install --path=.bundle
bundle exec jekyll build --verbose

gsutil -m cp -z html,css -a public-read -R _site "gs://docs.weave.works/${OUTPUT}"
gsutil -m rsync -d _site "gs://docs.weave.works/${OUTPUT}"

This comment was marked as abuse.

@paulbellamy
Copy link
Contributor

Will this not still make stuff look like: ${OUTPUT}/_site ?

@errordeveloper
Copy link
Contributor Author

Will this not still make stuff look like: ${OUTPUT}/_site ?

From what I am seeing, no.

@paulbellamy
Copy link
Contributor

LGTM

paulbellamy added a commit that referenced this pull request May 11, 2015
@paulbellamy paulbellamy merged commit 8f1f674 into weaveworks:master May 11, 2015
@rade rade modified the milestone: 0.11.0 May 12, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants