Skip to content
This repository has been archived by the owner on Jun 20, 2024. It is now read-only.

proxy needs to add weavewait to execs as well #703

Merged
merged 2 commits into from
May 19, 2015

Conversation

paulbellamy
Copy link
Contributor

Bug came up in a test where we are restarting and doing an exec checking
a network interface right away. weavewait is only added if the container
has a WEAVE_CIDR var set, the same as at container creation.

default:
http.Error(w, "Unable to intercept request", http.StatusInternalServerError)
Warning.Print("Error intercepting request: ", err)
}

This comment was marked as abuse.

This comment was marked as abuse.

This comment was marked as abuse.

This comment was marked as abuse.

This comment was marked as abuse.

Bug came up in a test where we are restarting and doing an exec checking
a network interface right away. weavewait is only added if the container
has a WEAVE_CIDR var set, the same as at container creation.
@paulbellamy
Copy link
Contributor Author

re: state UNKNOWN.
weave/net.EnsureInterface, does check the that the interface has the Up flag set, so it should definitely be waiting. I believe it's ip link show ethwe being a bit overly-specific/racey. ifconfig ethwe shows the interface as UP.

@rade
Copy link
Member

rade commented May 19, 2015

That seems a little odd. Could it be timing related, e.g. perhaps ifconfig is slower than ip? Or perhaps ip works off some information that is updated asynchronously. I wonder whether our resident kernel sleuth knows the answer. @dpw?

@rade rade added this to the 0.11.0 milestone May 19, 2015
rade added a commit that referenced this pull request May 19, 2015
proxy needs to add weavewait to execs as well
@rade rade merged commit fe36da2 into weaveworks:master May 19, 2015
@paulbellamy paulbellamy deleted the proxy-minimal branch May 20, 2015 08:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants