-
Notifications
You must be signed in to change notification settings - Fork 672
Drop traffic from docker0 bridge to weave bridge #704
Conversation
Hang on, need to amend the smoke test to check that this actually works |
OK, have extended the smoke test - had to kludge the exec_on thing a bit to get the negation in the right place. |
Why is the kludge necessary? Would wrapping in a |
Alternatively, |
Except once you've rebased from master there will be three call sites, so an |
Hmm, there's a problem with both your existing |
Note that we have to wrap the '!' in 'sh -c' to get the negation to work as expected.
Changed to |
# exec_on1 "c5 ! $PING $C3" | ||
exec_on1 "c3 sh -c \"! $PING $C1\"" | ||
exec_on1 "c5 sh -c \"! $PING $C1\"" | ||
exec_on1 "c5 sh -c \"! $PING $C3\"" |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
Annularized |
Drop traffic from docker0 bridge to weave bridge Fixes #620.
I've just a) committed a change for simplicity and consistency. |
Fixes #620, as discussed in comments there. All smoke tests still pass.