This repository has been archived by the owner on Jun 20, 2024. It is now read-only.
Fix use of "break" within "select" in LocalConnection actorLoop #731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From the golang spec: 'A "break" statement terminates execution of the innermost "for", "switch", or "select" statement within the same function.' But the LocalConnection actorLoop seems to assume it skips the "select" and terminates the enclosing "for". As a result, if something did conn.Shutdown(nil), it would not actually shutdown the connection. It turns out this is never a problem, because Shutdown is always called with a non-nil error, even though there is code in a few places to handle the nil case. By cleaning that up, the dubious "break" is eliminated.
rade
added a commit
that referenced
this pull request
May 22, 2015
Fix use of "break" within "select" in LocalConnection actorLoop
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From the golang spec: 'A "break" statement terminates execution of the
innermost "for", "switch", or "select" statement within the same
function.' But the LocalConnection actorLoop seems to assume it
skips the "select" and terminates the enclosing "for".
As a result, if something did conn.Shutdown(nil), it would not actually
shutdown the connection. It turns out this is never a problem, because
Shutdown is always called with a non-nil error, even though there is code
in a few places to handle the nil case. By cleaning that up, the dubious
"break" is eliminated.