Skip to content
This repository has been archived by the owner on Jun 20, 2024. It is now read-only.

Improve ipam status message before and after pending consensus #801

Merged
merged 2 commits into from
Jun 1, 2015

Conversation

bboreham
Copy link
Contributor

Use the presence of a ticker object to determine whether we are actually waiting for consensus.
I also pulled the 'pending' bit out of the if-I-have-a-ring clause, because it is of interest either way.

Status before anything has happened now looks like this:

Allocator subnet 10.3.0.0/16

and after one weave run:

Allocator subnet 10.3.0.0/16 awaiting consensus: Nodes known: 1, Quorum size: 5
Pending requests for Allocate for 8450fe9a4cf18299cc745d32b8d052ac9e6cb3f069710a58eaff19abed78d607, 

Fixes #787

@rade
Copy link
Member

rade commented May 30, 2015

I think the output when there are pending requests should look like this:

Allocator subnet 10.3.0.0/16 awaiting consensus: Nodes known: 1, Quorum size: 5
Pending requests:
  Allocate for 8450fe9a4cf18299cc745d32b8d052ac9e6cb3f069710a58eaff19abed78d607
  Allocate for ...

@bboreham bboreham removed their assignment Jun 1, 2015
rade added a commit that referenced this pull request Jun 1, 2015
Improve ipam status message before and after pending consensus

Fixes #787.
@rade rade merged commit 3332f94 into weaveworks:0.11 Jun 1, 2015
@rade rade added this to the 0.11.1 milestone Jun 1, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants