This repository has been archived by the owner on Jun 20, 2024. It is now read-only.
kill -0 $CONTAINER_PID does not work inside weaveexec container #830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -335,7 +335,7 @@ with_container_netns () { | |||
| shift 1 | |||
| if ! "$@" >$IP_TMPOUT 2>$IP_TMPERR ; then | |||
| STATUS=1 | |||
| if ! kill -0 "$CONTAINER_PID" 2>/dev/null ; then | |||
| if [ ! -d /$PROCFS/$CONTAINER_PID ] ; then | |||
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
since $CONTAINER_PID is in a different process namespace. Fixes weaveworks#829.
rade
force-pushed
the
829_fix_container_death_check
branch
from
d15e123
to
fa8b77b
Compare
rade
added a commit
that referenced
this pull request
Jun 3, 2015
kill -0 $CONTAINER_PID does not work inside weaveexec container Fixes #829.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
since $CONTAINER_PID is in a different process namespace.
Fixes #829.