This repository has been archived by the owner on Jun 20, 2024. It is now read-only.
include image name in errors #969
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The go docker client's ErrNoSuchImage does not include the image name. However, it is imperative that this name appears in error messages sent to clients, since the docker client, as of version 1.7.0, only automatically pulls images when their name is present in the error. Fixes weaveworks#967.
|
Why is this a PR into 1.0.0 and not master? I didn't notice that and pushed a merge to master. If it doesn't belong there it can be reverted, or it can be merged into 1.0.0. |
|
It's a PR on 1.0.0 because it is going to get released in a 1.0.1. So it should have been merged into 1.0.0 and then from there into master. |
|
Ops, I didn't get that memo. Does it matter if it happens the other way around? |
Yes. Because stuff has landed on master since 1.0.0. Why not merge this PR as intended, and then merge 1.0.0 into master (which should be a no-op)? |
squaremo
added a commit
that referenced
this pull request
Jun 20, 2015
…rror include image name in errors
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The go docker client's
ErrNoSuchImagedoes not include the image name. However, it is imperative that this name appears in error messages sent to clients, since the docker client, as of version1.7.0, only automatically pulls images when their name is present in the error.
Fixes #967.