Tidyup items.

weaveworks · Jul 4, 2023 · 87c7a34 · 87c7a34
1 parent 1ed555e
commit 87c7a34
Show file tree

Hide file tree

Showing 2 changed files with 37 additions and 45 deletions.
diff --git a/plugins/backstage-plugin-flux/README.md b/plugins/backstage-plugin-flux/README.md
@@ -76,6 +76,7 @@ import {
  FluxEntityHelmReleasesCard,
  FluxEntityGitRepositoriesCard,
  FluxEntityOCIRepositoriesCard,
+ FluxEntityHelmRepositoriesCard,
 } from '@weaveworksoss/backstage-plugin-flux';
 
 const serviceEntityPage = (
@@ -85,6 +86,9 @@ const serviceEntityPage = (
  <Grid item md={12}>
  <FluxEntityHelmReleasesCard />
  </Grid>
+ <Grid item md={12}>
+ <FluxEntityHelmRepositoriesCard />
+ </Grid>
  <Grid item md={12}>
  <FluxEntityGitRepositoriesCard />
  </Grid>

diff --git a/...lux/src/components/FluxEntityHelmRepositoriesCard/FluxEntityHelmRepositoriesCard.test.tsx b/...lux/src/components/FluxEntityHelmRepositoriesCard/FluxEntityHelmRepositoriesCard.test.tsx
@@ -96,42 +96,32 @@ const entity: Entity = {
 };
 
 describe('<FluxEntityHelmRepositoriesCard />', () => {
- let Wrapper: React.ComponentType<React.PropsWithChildren<{}>>;
-
- beforeEach(() => {
- Wrapper = ({ children }: { children?: React.ReactNode }) => (
- <div>{children}</div>
- );
- });
-
  beforeEach(() => {
  jest.resetAllMocks();
  });
 
  describe('when the config contains a link to Weave GitOps', () => {
  it('shows the state of a HelmRepository', async () => {
  const result = await renderInTestApp(
- <Wrapper>
- <TestApiProvider
- apis={[
- [
- configApiRef,
- new ConfigReader({
- gitops: { baseUrl: 'https://example.com/wego' },
- }),
- ],
- [kubernetesApiRef, new StubKubernetesClient()],
- [
- kubernetesAuthProvidersApiRef,
- new StubKubernetesAuthProvidersApi(),
- ],
- ]}
- >
- <EntityProvider entity={entity}>
- <FluxEntityHelmRepositoriesCard />
- </EntityProvider>
- </TestApiProvider>
- </Wrapper>,
+ <TestApiProvider
+ apis={[
+ [
+ configApiRef,
+ new ConfigReader({
+ gitops: { baseUrl: 'https://example.com/wego' },
+ }),
+ ],
+ [kubernetesApiRef, new StubKubernetesClient()],
+ [
+ kubernetesAuthProvidersApiRef,
+ new StubKubernetesAuthProvidersApi(),
+ ],
+ ]}
+ >
+ <EntityProvider entity={entity}>
+ <FluxEntityHelmRepositoriesCard />
+ </EntityProvider>
+ </TestApiProvider>
  );
 
  const { getByText } = result;
@@ -164,22 +154,20 @@ describe('<FluxEntityHelmRepositoriesCard />', () => {
  describe('when the config is not configured with a link to Weave GitOps', () => {
  it('does not include a link to Weave GitOps', async () => {
  const rendered = await renderInTestApp(
- <Wrapper>
- <TestApiProvider
- apis={[
- [configApiRef, new ConfigReader({})],
- [kubernetesApiRef, new StubKubernetesClient()],
- [
- kubernetesAuthProvidersApiRef,
- new StubKubernetesAuthProvidersApi(),
- ],
- ]}
- >
- <EntityProvider entity={entity}>
- <FluxEntityHelmRepositoriesCard />
- </EntityProvider>
- </TestApiProvider>
- </Wrapper>,
+ <TestApiProvider
+ apis={[
+ [configApiRef, new ConfigReader({})],
+ [kubernetesApiRef, new StubKubernetesClient()],
+ [
+ kubernetesAuthProvidersApiRef,
+ new StubKubernetesAuthProvidersApi(),
+ ],
+ ]}
+ >
+ <EntityProvider entity={entity}>
+ <FluxEntityHelmRepositoriesCard />
+ </EntityProvider>
+ </TestApiProvider>
  );
 
  const { getByText } = rendered;