Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI polish following internal demo #25

Merged
merged 2 commits into from
Jul 5, 2023
Merged

UI polish following internal demo #25

merged 2 commits into from
Jul 5, 2023

Conversation

AlinaGoaga
Copy link
Contributor

@AlinaGoaga AlinaGoaga commented Jul 5, 2023 •
edited
Loading

  • Add condition[Ready].message into the tooltip on status column.
  • Disable sync button if resource is suspended
  • Remove grey circle around shield icons
  • Can we change the OSS cluster name “Default” to something like demo-cluster? If not, tooltip of the string “Default” to say its the cluster? Prefix with “cluster: Default” in the name column?

@foot
Copy link
Collaborator

foot commented Jul 5, 2023

Reconciling is getting a little bit clipped for me on laptop screen

image

For you too? Maybe we reduce width of the "wide" columns a smidge? (350px -> 325px?)

foot
foot approved these changes Jul 5, 2023
View reviewed changes
Copy link
Collaborator

@foot foot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 🎉

@AlinaGoaga AlinaGoaga merged commit 5af19a0 into main Jul 5, 2023
1 check passed
@bigkevmcd bigkevmcd deleted the more-ui-polish branch July 12, 2023 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@foot foot foot approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AlinaGoaga @foot