Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump dependencies to Backstage v1.20.3 #61

Merged
merged 4 commits into from
Dec 1, 2023
Merged

Bump dependencies to Backstage v1.20.3 #61

merged 4 commits into from
Dec 1, 2023

Conversation

bigkevmcd
Copy link
Collaborator

This bumps the backstage dependencies to address #60

backstage-cli versions:bump

@bigkevmcd
Bump dependencies to Backstage v1.20.3
ca94664 
backstage-cli versions:bump
@foot
Adds canvas as an explicit dep
f82a1b7 
- xterm imports it at some point
- This stops our tests from generating loads of warnings
@foot
Fix up mock interfaces
889d93e
@foot
Rollback to react 17
2b129a2 
- and tanstack v4
- and some testing libraries
- create-backstage-app doesn't create a react 18 app yet, so
  unfortunately seems premature to require react 18
@foot
Copy link
Collaborator

foot commented Dec 1, 2023 •
edited
Loading

  • Downgrade the requirement of React 18 to React 17 (which was increased in Flux versions availability #59) , npx @backstage/create-app@latest is still creating React 17 apps by default. (downgrade tanstack/query to v4 that still support react 17 too).
  • Fix the test warning[0] by explicitly including canvas as a devDep (that kubernetes-common > * > xterm implicitly relies on.

[0]

    console.error
      Error: Not implemented: HTMLCanvasElement.prototype.getContext (without installing the canvas npm package)

foot
foot approved these changes Dec 1, 2023
View reviewed changes
Copy link
Collaborator

@foot foot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested

  • ./dev and clicked around
  • ./startup.sh, flux-runtime page, entity page, sync/suspend etc 👍

@bigkevmcd bigkevmcd merged commit 3f0a8f9 into main Dec 1, 2023
1 check passed
@bigkevmcd bigkevmcd deleted the bump-dependencies branch December 1, 2023 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@foot foot foot approved these changes

@AlinaGoaga AlinaGoaga Awaiting requested review from AlinaGoaga

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bigkevmcd @foot