Refactor gRPC Client and Protobuf Namespace #204
Merged
+428
−472
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![orca-security-eu[bot]](https://avatars.githubusercontent.com/in/276244?s=60&v=4){kind=small}
There was a problem hiding this comment.
Orca Security Scan Summary
| Status | Check | Issues by priority | |
|---|---|---|---|
 Passed |
Secrets |  0  0  0  0 |
View in Orca |
Summary - Weaviate C# Client CoverageSummary
CoverageWeaviate.Client - 59.3%
|
mpartipilo
force-pushed
the
chore/upgrade-dotnet
branch
from
4ef1ff1 to
7ce656c
Compare
- Updated the gRPC client implementation to use the new Grpc.Protobuf namespace for all client calls. - Changed the namespace from Weaviate.Client.gRPC to Weaviate.Client.Grpc for consistency. - Modified all references to V1 types to use Grpc.Protobuf.V1 in the client code. - Updated proto files to include the csharp_namespace option for proper namespace mapping. - Removed the obsolete file_replication.proto and adjusted the batch.proto for better structure. - Enhanced the BatchStreamRequest and BatchStreamReply messages for improved functionality. - Added a new GenerativeContextualAI message to the generative.proto file. - Updated the proto_sync.sh script to automatically add the csharp_namespace option to new proto files.
…date integration test workflow
mpartipilo
force-pushed
the
chore/relocate-protobuf-code
branch
from
18da084 to
dea9f8c
Compare
There was a problem hiding this comment.
Orca Security Scan Summary
| Status | Check | Issues by priority | |
|---|---|---|---|
| Passed |
Infrastructure as Code | 0 0 0 0 |
View in Orca |
| Passed |
SAST | 0 0 0 0 |
View in Orca |
| Passed |
Secrets | 0 0 0 0 |
View in Orca |
| Passed |
Vulnerabilities | 0 0 0 0 |
View in Orca |
mpartipilo
force-pushed
the
chore/relocate-protobuf-code
branch
from
dea9f8c to
7ae9796
Compare
mpartipilo
force-pushed
the
chore/relocate-protobuf-code
branch
from
7ae9796 to
104fe96
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the gRPC client to utilize the new Grpc.Protobuf namespace, ensuring consistency across the codebase. Enhance proto files with proper namespace mapping and introduce a new GenerativeContextualAI message for improved functionality. Clean up obsolete files and streamline the batch processing structure.