gh-175 Adds schema class exists method #196
Conversation
|
To avoid any confusion in the future about your contribution to Weaviate, we work with a Contributor License Agreement. If you agree, you can simply add a comment to this PR that you agree with the CLA so that we can merge. |
| private String className; | ||
|
|
||
| public ClassExists(HttpClient httpClient, Config config) { | ||
| this.classGetter = new ClassGetter(httpClient, config); |
There was a problem hiding this comment.
Avoid creating instances of dependencies inside classes. Instead create dependencies outside and inject them as arguments of constructor.
It will make testing a lot easier by using mocks instead of real implementations.
There was a problem hiding this comment.
this. prefix is not necessary here
src/main/java/io/weaviate/client/v1/schema/api/ClassExists.java
Outdated
Show resolved
Hide resolved
| WeaviateErrorMessage errorMessage = WeaviateErrorMessage.builder() | ||
| .message("classname cannot be empty").build(); | ||
| WeaviateErrorResponse errors = WeaviateErrorResponse.builder() | ||
| .error(Stream.of(errorMessage).collect(Collectors.toList())).build(); |
There was a problem hiding this comment.
Stream.of(errorMessage).collect(Collectors.toList())
although correct, stream seems to be a bit excessive here.
Arrays.asList(errorMessage) or Collections.singletonList(errorMessage) can be used instead.
src/main/java/io/weaviate/client/v1/schema/api/ClassExists.java
Outdated
Show resolved
Hide resolved
src/main/java/io/weaviate/client/v1/schema/api/ClassExists.java
Outdated
Show resolved
Hide resolved
|
Addressed the review comments in latest commit |
| return this; | ||
| } | ||
|
|
||
| private Result<Boolean> toResult(WeaviateError error) { |
There was a problem hiding this comment.
missed it, removed now
Addresses #175
client.schema().exists().withClassName("clazz").run(); //returns Result<Boolean>