Extend test suite for WeaviateAsyncClient #334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Found some bugs while porting the sync tests. The buggy test cases are @ignored; a commit with fixes will follow. Schema management: - classGetter - exists - classUpdater Sharding: - shardsGetter - shardsUpdater (FIXME) Multitennancy: - tennantsCreator (FIXME) - tennantsGetter (FIXME)
bevzzz
changed the title
![orca-security-eu[bot]](https://avatars.githubusercontent.com/in/276244?s=60&v=4){kind=small}
There was a problem hiding this comment.
Orca Security Scan Summary
| Status | Check | Issues by priority | |
|---|---|---|---|
 Passed |
Infrastructure as Code |  0  0  0  0 |
View in Orca |
| Passed |
Secrets | 0 0 0 0 |
View in Orca |
| Passed |
Vulnerabilities | 0 0 0 0 |
View in Orca |
ShardsUpdater must update all shards and result ShardStatus[]. Added shardUpdater (singular!) to async.Schema to mirror the sync implementation.
Return Boolean instead of the Tennant object. Added TenantExists to complement the existing test case. Extended base.Result to store the statusCode used in the constructor to create derived Result objects, like .withNewResult does.
|
OK, I just figured out that instead of the I'll update that part in Updated ✔️ |
Removed Result.withNewResult as it's no longer used anywhere.
Note, that GET /backups/<backend> is currently not supported on the server; both tests end up being skipped, but will automatically "re-activate" once the operation becomes supported.
aliszka
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR mirrors some of the "sync" unit test for the AsyncClient.
Schema management:
Sharding:
Multitenancy:
Backups:
The BackupGetter tests are skipped automatically, but will re-activate once "list backups" stops returning "not implemented".