Skip to content

Improve Embedded DB UX #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 4, 2023
Merged

Improve Embedded DB UX #31

merged 4 commits into from
Apr 4, 2023

Conversation

@parkerduckworth
Copy link
Member

@parkerduckworth parkerduckworth commented Mar 30, 2023 •
edited
Loading

  • set deterministic default CLUSTER_HOSTNAME
  • allow exported env vars to override hardcoded defaults

@parkerduckworth parkerduckworth requested a review from dirkkul March 30, 2023 18:17
etiennedi
etiennedi approved these changes Apr 4, 2023
View reviewed changes
Copy link
Member

@etiennedi etiennedi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@parkerduckworth parkerduckworth merged commit f5598f5 into main Apr 4, 2023
@parkerduckworth parkerduckworth deleted the embedded-improvements branch April 4, 2023 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dirkkul dirkkul dirkkul approved these changes

@etiennedi etiennedi etiennedi approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@parkerduckworth @dirkkul @etiennedi