Support CommonJs and ESM in hybrid package #53
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parkerduckworth
force-pushed
the
tsup-hybrid-lib-support
branch
from
fedcf19 to
018d79e
Compare
parkerduckworth
force-pushed
the
tsup-hybrid-lib-support
branch
from
018d79e to
cedc427
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce tsup to build the project in both commonjs and esm, exporting the use of both builds in the package.json. This is in contrast to the current setup of a single build which attempts to accommodate both build targets.
This change fixes a broken setup which was discovered when trying to use the embedded client within an esm project, which was a result of the emitted JS containing both require and import statements.