Typescript migration #121
Typescript migration #121
Conversation
parkerduckworth
left a comment
parkerduckworth
left a comment
There was a problem hiding this comment.
Hey @cnadeau thanks for this! Looks good so far. Next, let's get the tests into a passing state.
I know what the problem is, I'll have a look asap, thanks! |
|
By the way, here is a branch where I started the TS migration awhile back: All the tests were green on the last commit. Feel free to take a look if needed |
|
To avoid any confusion in the future about your contribution to Weaviate, we work with a Contributor License Agreement. If you agree, you can simply add a comment to this PR that you agree with the CLA so that we can merge. |
|
@parkerduckworth There is single one failing, I'll try to have a look tonight. In the meantime, you can review the other PRs I'll convert the new features/bugfixes on top if this PR once they are in Sorry for the delays, I wasn't able to run the ci docker-compose stack for some reason |
|
@cnadeau the client was somewhat of a moving target in preparation for weaviate server version 1.18 release. Things should be more stable now |
|
@cnadeau How is this progressing? Do you have any estimation of when this will be available? |
…f errors found in the lib)
ts-jest ignores tsconfig path into consideration as expected in documentation https://kulshekhar.github.io/ts-jest/docs/getting-started/options/tsconfig
…t and not the Connection instance directly (bad decision while converting)
…-in request with username/password' test
4 participants
REF Issue: #19
It's a direct conversion, nothing fancy as a first step. Still a lot of
:anytypes, but it's a start!Next steps: It would be nice to be able to get generics for Class properties typing and be able to use interfaces for create/update/read operations.