Skip to content

Commit

Permalink
Fix versions for tests
Browse files Browse the repository at this point in the history
  • Loading branch information
dirkkul committed Oct 4, 2024
1 parent bce9a5a commit 4e7170c
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 5 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/main.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ on:
env:
WEAVIATE_123: 1.23.16
WEAVIATE_124: 1.24.25
WEAVIATE_125: 1.25.17
WEAVIATE_125: 1.25.18
WEAVIATE_126: 1.26.5

jobs:
Expand Down
10 changes: 6 additions & 4 deletions integration/test_collection_config.py
Original file line number Diff line number Diff line change
Expand Up @@ -343,10 +343,12 @@ def test_collection_config_full(collection_factory: CollectionFactory) -> None:
assert config.replication_config.async_enabled is True
else:
assert config.replication_config.async_enabled is False
assert (
config.replication_config.object_deletion_conflict_resolution
== wvc.config.ObjectDeletionConflictResolution.PERMANENT_DELETION
)

if collection._connection._weaviate_version.is_at_least(1, 25, 18):
assert (
config.replication_config.object_deletion_conflict_resolution
== wvc.config.ObjectDeletionConflictResolution.PERMANENT_DELETION
)

assert isinstance(config.vector_index_config, _VectorIndexConfigHNSW)
assert isinstance(config.vector_index_config.quantizer, _PQConfig)
Expand Down

0 comments on commit 4e7170c

Please sign in to comment.