Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make internal function private #1049

Merged
merged 1 commit into from
May 8, 2024
Merged

Make internal function private #1049

merged 1 commit into from
May 8, 2024

Conversation

dirkkul
Copy link
Collaborator

@dirkkul dirkkul commented May 8, 2024

the function would be available for auto-complete:

    with collection.batch.dynamic() as batch:
        batch.dynamic_batch_rate_loop()

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.62%. Comparing base (80be3c5) to head (b05a3b0).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1049      +/-   ##
==========================================
+ Coverage   94.57%   94.62%   +0.05%     
==========================================
  Files         181      181              
  Lines       18751    18751              
==========================================
+ Hits        17733    17743      +10     
+ Misses       1018     1008      -10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dirkkul dirkkul merged commit f5ac472 into main May 8, 2024
43 checks passed
@dirkkul dirkkul deleted the private_function branch May 8, 2024 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants