-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix type boolean restriction on include vector for _QueryReference #1399
fix type boolean restriction on include vector for _QueryReference #1399
Conversation
To avoid any confusion in the future about your contribution to Weaviate, we work with a Contributor License Agreement. If you agree, you can simply add a comment to this PR that you agree with the CLA so that we can merge. |
I agree with the Contributor License Agreement. |
hey Tommy, i fixed the error related to lower versions not supporting namedVectors. but not quite sure whats triggering this one: https://github.com/weaviate/weaviate-python-client/actions/runs/11780176232/job/32810722328?pr=1399 |
Hi @paul7Junior, that fail looks like a known flake, which sadly there are a few in the CI! I'll rerun the tests again until they are all green and then I'll give it a review. Thanks so much for this contribution ❤️ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the added test! Only one comment about it, feel free to say no and we can merge it as it is 😛
Thank you! |
This pull request is a proposed solution for the issue opened #1400
This change the type validation on include_vector parameter for _QueryReference that prevents from requesting named vectors using array of string on references as it would force you to pull all vectors with True, which is not convenient if you have a lots of vectors.
But using True seems like would not work either and is related to another issue I opened here: weaviate/weaviate#6279
This is my first pull request on here, happy to get feedbacks and add more tests.