Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix clientwide mypy errors #482

Merged
merged 18 commits into from
Sep 6, 2023
Merged

Fix clientwide mypy errors #482

merged 18 commits into from
Sep 6, 2023

Conversation

tsmith023
Copy link
Contributor

@tsmith023 tsmith023 commented Sep 5, 2023

This PR implements a number of small fixes to ready the package for full mypy compliance

Once it's established, a pre-commit hook and a Github action will be added that run mypy sweeps of the codebase

In this initial PR, only /weaviate will be type checked but in future this should be extended to /test and /integration

Copy link
Collaborator

@dirkkul dirkkul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very cool :)

weaviate/batch/crud_batch.py Outdated Show resolved Hide resolved
weaviate/batch/crud_batch.py Outdated Show resolved Hide resolved
@weaviate-git-bot
Copy link

Great to see you again! Thanks for the contribution.

beep boop - the Weaviate bot 👋🤖

PS:
Are you already a member of the Weaviate Slack channel?

@tsmith023 tsmith023 marked this pull request as ready for review September 6, 2023 09:39
@tsmith023 tsmith023 requested a review from a team as a code owner September 6, 2023 09:39
@codecov-commenter
Copy link

Codecov Report

Patch coverage: 91.91% and project coverage change: -0.55% ⚠️

Comparison is base (eb3bf16) 95.43% compared to head (92332b8) 94.88%.
Report is 127 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #482      +/-   ##
==========================================
- Coverage   95.43%   94.88%   -0.55%     
==========================================
  Files          64       72       +8     
  Lines        8165     8658     +493     
==========================================
+ Hits         7792     8215     +423     
- Misses        373      443      +70     
Files Changed Coverage Δ
weaviate/util.py 91.01% <72.91%> (-5.32%) ⬇️
weaviate/batch/crud_batch.py 78.11% <75.00%> (-17.21%) ⬇️
weaviate/schema/crud_schema.py 81.98% <80.55%> (+3.82%) ⬆️
weaviate/connect/connection.py 89.30% <83.87%> (+0.36%) ⬆️
weaviate/gql/aggregate.py 82.97% <85.45%> (+7.11%) ⬆️
mock_tests/test_exception.py 87.50% <87.50%> (ø)
weaviate/connect/authentication.py 96.15% <87.50%> (+8.15%) ⬆️
weaviate/exceptions.py 90.69% <87.50%> (-0.74%) ⬇️
weaviate/classification/config_builder.py 98.82% <88.88%> (-1.18%) ⬇️
weaviate/gql/filter.py 93.95% <93.69%> (-0.40%) ⬇️
... and 28 more

... and 6 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

.github/workflows/main.yaml Show resolved Hide resolved
requirements-mypy.txt Outdated Show resolved Hide resolved
.pre-commit-config.yaml Show resolved Hide resolved
@tsmith023 tsmith023 merged commit d383f04 into main Sep 6, 2023
@tsmith023 tsmith023 deleted the fix-clientwide-mypy-errors branch September 6, 2023 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants