-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix clientwide mypy errors #482
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
very cool :)
Great to see you again! Thanks for the contribution. |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #482 +/- ##
==========================================
- Coverage 95.43% 94.88% -0.55%
==========================================
Files 64 72 +8
Lines 8165 8658 +493
==========================================
+ Hits 7792 8215 +423
- Misses 373 443 +70
☔ View full report in Codecov by Sentry. |
This PR implements a number of small fixes to ready the package for full
mypy
complianceOnce it's established, a
pre-commit
hook and a Github action will be added that runmypy
sweeps of the codebaseIn this initial PR, only
/weaviate
will be type checked but in future this should be extended to/test
and/integration