Skip to content

Fix motion path effect when sampling at end of interval #513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix motion path effect when sampling at end of interval #513

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
46abb94
Fix motion path effect when sampling at end of interval.
birtles Dec 11, 2013
d5a0a94
Add some brackets
birtles Dec 11, 2013
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions web-animations.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1694,8 +1694,12 @@ PathAnimationEffect.prototype = createObject(AnimationEffect.prototype, {
}
},
_sample: function(timeFraction, currentIteration, target) {
if (timeFraction === null) {
return;
}
// TODO: Handle accumulation.
var lengthAtTimeFraction = this._lengthAtTimeFraction(timeFraction);
ASSERT_ENABLED && assert(isFinite(lengthAtTimeFraction));
var point = this._path.getPointAtLength(lengthAtTimeFraction);
var x = point.x - target.offsetWidth / 2;
var y = point.y - target.offsetHeight / 2;
Expand All @@ -1721,6 +1725,10 @@ PathAnimationEffect.prototype = createObject(AnimationEffect.prototype, {
}
var scaledFraction = timeFraction * segmentCount;
var index = clamp(Math.floor(scaledFraction), 0, segmentCount);
// Special handling for when we reach the end
if (index >= segmentCount) {
return this._cumulativeLengths[segmentCount];
}
return this._cumulativeLengths[index] + ((scaledFraction % 1) * (
this._cumulativeLengths[index + 1] - this._cumulativeLengths[index]));
},
Expand Down