Fix to encode/decode credential id as base64url #631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The decoding method in the Credential class was updated to use 'decodeNoPadding' from Base64UrlSafe. This change improves efficiency and matches the desired coding style.
|
Many thanks! |
|
Thank you for fixing my mistake and merging my pull request! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Target branch: 4.9.x
Resolves issue #
Previously, the
idof the PublicKeyCredential obtained by the PublicKeyCredentialDenormalizer was a raw base64url encoded string sent by the browser. However, with change #589, it is now converted to a base64-encoded string. This pull request reverts this behavior back to the previous one.Also, I think it is correct to decode if only
$idis passed when creating an instance, so I fixed this as well.