Deprecate 'icon' parameter from PublicKeyCredentialCreationOptionsFac… #635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Spomky
added
the
compliance
Spomky
force-pushed
the
deprecations/icon
branch
from
830aae9 to
8432b2f
Compare
The 'icon' parameter has been removed from the creation of PublicKeyCredentialEntity objects and their related tests. This is done due to it being deprecated in version 5.1 and has no effect currently. Relevant changes in the normalized results have also been made accordingly in the test cases.
Spomky
force-pushed
the
deprecations/icon
branch
from
8432b2f to
b61e4ea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…tory and related methods
The 'icon' parameter was deprecated from the PublicKeyCredentialCreationOptionsFactory and associated methods to reflect the latest specification change. The serializer and deserializer were also updated accordingly. To avoid unexpected breaks, a deprecation warning has been added when 'icon' parameter is used in the PublicKeyCredentialEntity.
Target branch: 5.1.x
Resolves issue #634