-
-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set default algorithms for pubKeyCredParams #646
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Related to w3c/webauthn#1757 |
Spomky
added
DX
Developer Experience
compliance
Issue related to the compliance of the project with the specs
UX
labels
Sep 9, 2024
@mergify rebase |
☑️ Nothing to do
|
@mergify rebase |
✅ Branch has been successfully rebased |
Spomky
force-pushed
the
default_algorithms
branch
from
September 9, 2024 06:29
4868f92
to
72a7b7c
Compare
@mergify rebase |
❌ Base branch update has failedGit reported the following error:
|
Spomky
force-pushed
the
default_algorithms
branch
from
September 9, 2024 11:36
72a7b7c
to
d37808f
Compare
Hi, I tried to rebase it and merge into 5.0.x, but it looks like I do not have the permissions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Target branch:
PublicKeyCredentialCreationOptions
can be created with an emptypubKeyCredParams
array by default. However, some of the authenticators (like NordPass) don't support this. They are crashed when no algorithms are provided for registration options. Other authenticators (like 1Password) useES256 (-7)
by default on their side in such case.@simplewebauthn/server
sets [-8, -7, -257] algorithms by default. The same is done by W3C Webauthn specification.This PR suggests to do the same.
Also, there is incorrect information in the documentation:
It's not true right now: an empty array is sent to the authenticator.