Skip to content

Conversation

@yuyutaotao
Copy link
Collaborator

Summary

  • allow aiScroll's scrollType to accept legacy aliases like once alongside current options
  • extend scroll parameter types to advertise the backward-compatible values

Testing

  • not run

Codex Task

@netlify
Copy link

netlify bot commented Dec 19, 2025

Deploy Preview for midscene ready!

Name Link
🔨 Latest commit a266177
🔍 Latest deploy log https://app.netlify.com/projects/midscene/deploys/69453eb3032f5c0008fdb029
😎 Deploy Preview https://deploy-preview-1636--midscene.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines 251 to 255
'once',
'untilBottom',
'untilTop',
'untilRight',
'untilLeft',

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Legacy scroll aliases still unsupported at runtime

Allowing legacy values in the scroll schema (these enum entries) means YAML flows or direct callActionInActionSpace calls using scrollType: 'once'/'untilBottom' now pass validation, but the platform actions still branch only on the canonical names and throw Unknown scroll event type for anything else (see packages/web-integration/src/web-page.ts lines 494-519 and packages/android/src/device.ts lines 155-183). A script using the newly accepted aliases will therefore fail at runtime instead of performing the intended scroll, so the backward compatibility advertised by this change is not actually achieved.

Useful? React with 👍 / 👎.

@yuyutaotao yuyutaotao merged commit 58dc451 into main Dec 19, 2025
10 checks passed
@yuyutaotao yuyutaotao deleted the codex/update-aiscroll-type-for-scrolltype-parameter branch December 19, 2025 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants