fix(visualizer): prevent long reportHTML from being displayed in playground output #1730
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ground output
Fixed an issue where aiWaitFor (and other APIs returning undefined) would
display the entire reportHTML content in the playground output section.
The problem occurred because the result extraction logic used
`if (resultObj.result !== undefined)` which failed to extract undefined
values. This caused the entire response object (including the long
reportHTML string) to remain in result.result and be displayed via
JSON.stringify.
Changed the condition to `if ('result' in resultObj)` to properly handle
undefined values, ensuring result.result is set to undefined instead of
the wrapped response object.
✅ Deploy Preview for midscene ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
yuyutaotao
approved these changes
Jan 7, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixed an issue where
aiWaitFor(and other APIs returningundefined) would display the entirereportHTMLcontent in the playground output section, causing very long and unreadable text to appear.Root Cause
The problem occurred in
usePlaygroundExecution.tswhere the result extraction logic used:This condition failed to handle cases where
resultObj.resultisundefined, causing:local-execution.tswraps the result as:{ result: undefined, dump: {...}, reportHTML: "long HTML string" }result.resultbecauseundefined !== undefinedisfalsereportHTML) remained inresult.resultJSON.stringify(result.result), showing the entire HTML stringSolution
Changed the condition to use the
inoperator:This properly handles
undefinedvalues by checking for property existence rather than value comparison, ensuringresult.resultis correctly set toundefinedinstead of the wrapped response object.Test Plan
undefinedvalues correctlyScreenshots
Before: Long HTML/JavaScript text displayed in output
After: Clean output with only the actual result displayed