Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: using swc-jest instead of esbuild jest #1427

Merged
merged 3 commits into from
Jul 29, 2022

Conversation

chenjiahan
Copy link
Member

@chenjiahan chenjiahan commented Jul 29, 2022

PR Details

Description

esbuild-jest is no longer maintained, and have several bugs:

We can use @swc/jest to replace it.

PS: The code coverage is decreased from 60%+ to 50%+ because the coverage is calculated differently.

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • I have updated changeset
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@changeset-bot
Copy link

changeset-bot bot commented Jul 29, 2022

⚠️ No Changeset found

Latest commit: d41a69f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov
Copy link

codecov bot commented Jul 29, 2022

Codecov Report

Merging #1427 (d41a69f) into main (1c9199d) will decrease coverage by 10.98%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             main    #1427       +/-   ##
===========================================
- Coverage   63.15%   52.16%   -10.99%     
===========================================
  Files         748      693       -55     
  Lines       31033    17213    -13820     
  Branches     5902     3638     -2264     
===========================================
- Hits        19598     8979    -10619     
+ Misses      11402     7600     -3802     
- Partials       33      634      +601     
Impacted Files Coverage Δ
...kages/solutions/module-tools/src/utils/readline.ts 8.33% <0.00%> (-61.67%) ⬇️
.../cli/plugin-testing/src/runtime-testing/request.ts 10.00% <0.00%> (-60.00%) ⬇️
packages/cli/plugin-changeset/src/commands/pre.ts 16.66% <0.00%> (-58.34%) ⬇️
packages/solutions/monorepo-tools/src/log/utils.ts 16.66% <0.00%> (-58.34%) ⬇️
packages/toolkit/utils/src/clearConsole.ts 33.33% <0.00%> (-57.15%) ⬇️
...erator/generator-common/src/common/package-name.ts 20.00% <0.00%> (-56.93%) ⬇️
packages/solutions/app-tools/src/utils/language.ts 25.00% <0.00%> (-56.82%) ⬇️
...ges/solutions/monorepo-tools/src/utils/language.ts 25.00% <0.00%> (-56.82%) ⬇️
...cli/webpack/src/config/features/bundle-analyzer.ts 25.00% <0.00%> (-56.82%) ⬇️
...ugin-testing/src/runtime-testing/resolvePlugins.ts 10.00% <0.00%> (-54.29%) ⬇️
... and 738 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c9199d...d41a69f. Read the comment docs.

@chenjiahan chenjiahan merged commit 5ca8ed6 into web-infra-dev:main Jul 29, 2022
@chenjiahan chenjiahan deleted the swc_jest_0729 branch July 29, 2022 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants