Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

types: export HtmlRspackPlugin type #2861

Merged
merged 1 commit into from
Jul 10, 2024
Merged

types: export HtmlRspackPlugin type #2861

merged 1 commit into from
Jul 10, 2024

Conversation

chenjiahan
Copy link
Member

@chenjiahan chenjiahan commented Jul 10, 2024

Summary

Export HtmlRspackPlugin type for plugins to use.

This helps plugin-rem or plugin-assets-retry to remove the html-rspack-plugin dependency. We should provide more HTML-related plugin hooks for Rsbuild plugins in the future to reduce the dependency on html-rspack-plugin hooks.

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copy link

netlify bot commented Jul 10, 2024

Deploy Preview for rsbuild ready!

Name Link
🔨 Latest commit 6e18a26
🔍 Latest deploy log https://app.netlify.com/sites/rsbuild/deploys/668df8d2e48d0f0008becae6
😎 Deploy Preview https://deploy-preview-2861--rsbuild.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 80 (🔴 down 5 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@chenjiahan chenjiahan merged commit 5e40840 into main Jul 10, 2024
12 checks passed
@chenjiahan chenjiahan deleted the html_plugin_type_0710 branch July 10, 2024 03:08
@9aoy 9aoy mentioned this pull request Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant