Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): add type option to dev.watchFiles to support reload server #3069

Merged
merged 4 commits into from
Jul 30, 2024

Conversation

kurorinto
Copy link
Contributor

@kurorinto kurorinto commented Jul 30, 2024

Summary

Add type option to dev.watchFiles to choose 'reload-page'(default) or 'reload-server'

Type

type WatchFiles = {
  paths: string | string[];
  options?: WatchOptions;
  type?: 'reload-page' | 'reload-server';
};

Usage

  • type: 'reload-page' is the default value, align with the current usage.
export default {
  dev: {
    watchFiles: {
      type: 'reload-page',
      paths: ['public/foo.txt'],
    },
  },
};
  • type: 'reload-server' is the new value, can be used to watch some config files and reload the server.
import proxy from './configs/proxy.ts';

export default {
  dev: {
    watchFiles: {
      type: 'reload-server',
      paths: ['configs/proxy.ts'],
    },
  },
  server: {
    proxy,
  },
};

Related Links

#3057

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copy link

netlify bot commented Jul 30, 2024

Deploy Preview for rsbuild ready!

Name Link
🔨 Latest commit 072bc97
🔍 Latest deploy log https://app.netlify.com/sites/rsbuild/deploys/66a8ef49f913f00008fe5dc3
😎 Deploy Preview https://deploy-preview-3069--rsbuild.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 78 (🟢 up 2 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@chenjiahan chenjiahan changed the title feat(core): add type option to dev.watchFiles to choose 'reload-page'(default) or 'reload-server' feat(core): add type option to dev.watchFiles to support reload server Jul 30, 2024
Copy link
Member

@chenjiahan chenjiahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! ❤️

@chenjiahan chenjiahan merged commit c79bfc8 into web-infra-dev:main Jul 30, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants