Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!(cli): rename env option of inspect command to mode #3140

Merged
merged 1 commit into from
Aug 6, 2024

Conversation

chenjiahan
Copy link
Member

@chenjiahan chenjiahan commented Aug 6, 2024

Summary

Rename the env option of rsbuild inspect command to mode. This is to align with other APIs, such as the mode option of rsbuild.build().

# before
npx rsbuild inspect --env production

# after
npx rsbuild inspect --mode production

Related Links

https://rsbuild.dev/api/javascript-api/instance#rsbuildbuild

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copy link

netlify bot commented Aug 6, 2024

Deploy Preview for rsbuild ready!

Name Link
🔨 Latest commit 02e8c5d
🔍 Latest deploy log https://app.netlify.com/sites/rsbuild/deploys/66b1dacd6dcb5a0009445ef6
😎 Deploy Preview https://deploy-preview-3140--rsbuild.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 75 (🟢 up 23 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@chenjiahan chenjiahan requested a review from 9aoy August 6, 2024 08:12
@chenjiahan chenjiahan merged commit 1cedcca into main Aug 6, 2024
10 of 11 checks passed
@chenjiahan chenjiahan deleted the inspect_mode_0806 branch August 6, 2024 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant