Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(plugin-swc): should verify the version correctly #3364

Merged
merged 2 commits into from
Sep 3, 2024
Merged

Conversation

yimingjfe
Copy link
Member

Summary

At present, when verifying the react beta version is inaccurate. For example, verify18.3.0-canary-8039e6d0b-20231026 return false.

Related Links

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copy link

netlify bot commented Sep 3, 2024

Deploy Preview for rsbuild ready!

Name Link
🔨 Latest commit 1dc7a33
🔍 Latest deploy log https://app.netlify.com/sites/rsbuild/deploys/66d6f914c9541e00085f3a74
😎 Deploy Preview https://deploy-preview-3364--rsbuild.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 76 (🟢 up 1 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: 60 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@chenjiahan chenjiahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@chenjiahan chenjiahan enabled auto-merge (squash) September 3, 2024 11:52
@chenjiahan chenjiahan merged commit 51f1b1c into main Sep 3, 2024
9 checks passed
@chenjiahan chenjiahan deleted the fix-version branch September 3, 2024 12:02
@chenjiahan chenjiahan mentioned this pull request Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants