Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: lightningcss-loader not work when using PostCSS #3396

Merged
merged 4 commits into from
Sep 6, 2024

Conversation

chenjiahan
Copy link
Member

Summary

When using Rspack's builtin:lightningcss-loader like this:

postcss-loader ---passing AST meta---> builtin:lightningcss-loader ---passing AST meta---> css-loader

The builtin:lightningcss-loader will not take any effect, because css-loader will read the AST meta from postcss-loader, and drop the transformation result of builtin:lightningcss-loader.

Related Links

web-infra-dev/rspack#7819
#3247

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copy link

netlify bot commented Sep 6, 2024

Deploy Preview for rsbuild ready!

Name Link
🔨 Latest commit c4e78ce
🔍 Latest deploy log https://app.netlify.com/sites/rsbuild/deploys/66da9824fc8f89000864e6d1
😎 Deploy Preview https://deploy-preview-3396--rsbuild.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 77 (🟢 up 6 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: 60 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@chenjiahan chenjiahan merged commit f22abba into main Sep 6, 2024
9 checks passed
@chenjiahan chenjiahan deleted the fix_lightningcss_0906 branch September 6, 2024 06:02
@chenjiahan chenjiahan mentioned this pull request Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant