Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(plugin-stylus): support define option #3434

Merged

Conversation

shulaoda
Copy link
Contributor

Summary

Related Links

closes #3430

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@shulaoda shulaoda marked this pull request as draft September 10, 2024 07:19
Copy link

netlify bot commented Sep 10, 2024

Deploy Preview for rsbuild ready!

Name Link
🔨 Latest commit eb8dc46
🔍 Latest deploy log https://app.netlify.com/sites/rsbuild/deploys/66dffbd19c9ea60008bb465d
😎 Deploy Preview https://deploy-preview-3434--rsbuild.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 74 (no change from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: 60 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@shulaoda shulaoda marked this pull request as ready for review September 10, 2024 07:42
@shulaoda
Copy link
Contributor Author

Let me see if I can refine the any type to a more specific type.

@shulaoda shulaoda marked this pull request as draft September 10, 2024 07:43
@shulaoda shulaoda marked this pull request as ready for review September 10, 2024 07:56
@shulaoda shulaoda force-pushed the feat/support-define-for-plugin-stylus branch from 89075bc to eb8dc46 Compare September 10, 2024 07:57
Copy link
Member

@chenjiahan chenjiahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

@chenjiahan chenjiahan merged commit 0d39226 into web-infra-dev:main Sep 10, 2024
9 checks passed
@shulaoda shulaoda deleted the feat/support-define-for-plugin-stylus branch September 10, 2024 08:31
@binarykitchen
Copy link

Nice, thanks. Maybe update documentation as well next time?

@shulaoda
Copy link
Contributor Author

Nice, thanks. Maybe update documentation as well next time?

Let me do it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: More Stylus options
3 participants