fix(plugin-react): allow configuring tools.swc to override react runtime
#3449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for rsbuild ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
SoonIter
reviewed
Sep 11, 2024
| @@ -46,7 +46,7 @@ export const pluginBasic = (): RsbuildPlugin => ({ | |||
| }, | |||
| }); | |||
|
|
|||
| const usingHMR = !isProd && config.dev.hmr && target === 'web'; | |||
| const usingHMR = isDev && config.dev.hmr && target === 'web'; | |||
There was a problem hiding this comment.
Is it okay to do this change?
I see the snapshots of webpack and svgr are not as same as before
There was a problem hiding this comment.
These is also one place of usingHMR
There was a problem hiding this comment.
Yes, it is expected, we should only enable HMR when mode is development.
SoonIter
approved these changes
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Allow configuring
tools.swcto override react runtime.Related Links
resolve #3418
Checklist