feat(core): warn leading slash for output.distPath.html and default to ./
#3462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
✅ Deploy Preview for rsbuild ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
wjw99830
force-pushed
the
feature/dist_path_leading_slash
branch
from
03c3183
to
8c75ea7
Compare
chenjiahan
reviewed
Sep 12, 2024
Yeah, i think so too. |
|
Yes, we don't want to introduce breaking changes, we can maintain compatibility with the previous behavior and print a warning if the user passes an absolute path to |
…pting absolute path
wjw99830
force-pushed
the
feature/dist_path_leading_slash
branch
from
8c75ea7
to
e57246c
Compare
chenjiahan
reviewed
Sep 13, 2024
chenjiahan
reviewed
Sep 13, 2024
There was a problem hiding this comment.
The PR title can be updated~
chenjiahan
reviewed
Sep 13, 2024
| @@ -3,7 +3,7 @@ import { join } from 'node:path'; | |||
| // Paths | |||
| // loaders will be emitted to the same folder of the main bundle | |||
| export const ROOT_DIST_DIR = 'dist'; | |||
| export const HTML_DIST_DIR = '/'; | |||
| export const HTML_DIST_DIR = './'; | |||
There was a problem hiding this comment.
The default value in documentation can be updated too
wjw99830
changed the title
wjw99830
changed the title
./
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Currently the default value of
output.distPath.htmlis/. It's relative tooutput.distPath.root.But other props(like
js,css...) cannot be/, because they're relative to the root of file system.Related Links
https://rsbuild.dev/config/output/dist-path
Checklist