Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: avoid requiring empty module #3538

Merged
merged 2 commits into from
Sep 24, 2024
Merged

perf: avoid requiring empty module #3538

merged 2 commits into from
Sep 24, 2024

Conversation

chenjiahan
Copy link
Member

Summary

Avoid requiring the empty semver module, use inlined code instead.

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copy link

netlify bot commented Sep 23, 2024

Deploy Preview for rsbuild ready!

Name Link
🔨 Latest commit cfca535
🔍 Latest deploy log https://app.netlify.com/sites/rsbuild/deploys/66f17d1f2c85940008c597f6
😎 Deploy Preview https://deploy-preview-3538--rsbuild.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 72 (🔴 down 2 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: 60 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@chenjiahan chenjiahan merged commit ebe1a12 into main Sep 24, 2024
10 checks passed
@chenjiahan chenjiahan deleted the empty_semver_0923 branch September 24, 2024 02:18
@9aoy 9aoy mentioned this pull request Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant