Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: clean up unused internal helpers #3977

Merged
merged 3 commits into from
Nov 14, 2024
Merged

Conversation

chenjiahan
Copy link
Member

@chenjiahan chenjiahan commented Nov 14, 2024

Summary

Clean up some unused internal helpers. We can accept a few code duplications to ensure that private APIs are not abused.

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copy link

netlify bot commented Nov 14, 2024

Deploy Preview for rsbuild ready!

Name Link
🔨 Latest commit d27bbc6
🔍 Latest deploy log https://app.netlify.com/sites/rsbuild/deploys/6735fc348872330007f002d1
😎 Deploy Preview https://deploy-preview-3977--rsbuild.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 72 (🟢 up 1 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: 60 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@chenjiahan chenjiahan merged commit 66b9bb6 into main Nov 14, 2024
9 checks passed
@chenjiahan chenjiahan deleted the internal_helpers_1114 branch November 14, 2024 13:58
@chenjiahan chenjiahan mentioned this pull request Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant