Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(webpack): move Rslib to devDependencies #3990

Merged
merged 1 commit into from
Nov 16, 2024

Conversation

colinaaa
Copy link
Contributor

Summary

Avoid installing Rslib as dependencies of @rsbuild/plugin-webpack-swc.

Related Links

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copy link

netlify bot commented Nov 16, 2024

Deploy Preview for rsbuild ready!

Name Link
🔨 Latest commit 470dd70
🔍 Latest deploy log https://app.netlify.com/sites/rsbuild/deploys/6738454e7e304e0008a63a01
😎 Deploy Preview https://deploy-preview-3990--rsbuild.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 81 (🟢 up 11 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: 60 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@chenjiahan chenjiahan changed the title chore(webpack): move Rslib to devDependencies fix(webpack): move Rslib to devDependencies Nov 16, 2024
@chenjiahan
Copy link
Member

NIce catch 👍

@chenjiahan chenjiahan merged commit 5fcd7eb into web-infra-dev:main Nov 16, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants