Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve favicon handling with better error logging #4674

Merged
merged 4 commits into from
Feb 27, 2025

Conversation

chenjiahan
Copy link
Member

@chenjiahan chenjiahan commented Feb 27, 2025

Summary

Improve favicon handling with better error logging, now favicon errors can be displayed on the error overlay.

image

image

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copy link

netlify bot commented Feb 27, 2025

Deploy Preview for rsbuild ready!

Name Link
🔨 Latest commit 65e6260
🔍 Latest deploy log https://app.netlify.com/sites/rsbuild/deploys/67c0656478b6bf0008112762
😎 Deploy Preview https://deploy-preview-4674--rsbuild.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 40 (🔴 down 19 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: 60 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@chenjiahan chenjiahan merged commit cdcf526 into main Feb 27, 2025
11 checks passed
@chenjiahan chenjiahan deleted the favicon_error_message_0227 branch February 27, 2025 13:44
@9aoy 9aoy mentioned this pull request Feb 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant