Skip to content

Conversation

@chenjiahan
Copy link
Member

@chenjiahan chenjiahan commented Nov 21, 2025

Summary

  • Updated the browserslist cache key to separate path and environment values, preventing collisions between different project paths or NODE_ENV combinations.

Codex Task

Copilot AI review requested due to automatic review settings November 21, 2025 00:58
@netlify
Copy link

netlify bot commented Nov 21, 2025

Deploy Preview for rsbuild ready!

Name Link
🔨 Latest commit 17fd67c
🔍 Latest deploy log https://app.netlify.com/projects/rsbuild/deploys/691fb91e374a470008d33a17
😎 Deploy Preview https://deploy-preview-6620--rsbuild.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 62 (🟢 up 16 from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: 60 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR improves the browserslist cache key generation by replacing string concatenation with a template literal that uses a colon delimiter. The associated regression test was removed from helpers.test.ts as mentioned in the PR description.

  • Improved cache key format to use ${path}:${env ?? ''} instead of path + env
  • Removed browserslist cache regression test

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@chenjiahan chenjiahan changed the title fix: remove browserslist cache test fix: improve browserslist cache key Nov 21, 2025
@chenjiahan chenjiahan merged commit 733a61a into main Nov 21, 2025
20 checks passed
@chenjiahan chenjiahan deleted the codex/fix-bug-in-packages/core/src branch November 21, 2025 01:48
@chenjiahan chenjiahan mentioned this pull request Nov 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants