test(e2e): reorganize manifest related cases #6644
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for rsbuild ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR reorganizes manifest-related e2e test cases to improve code organization and maintainability by splitting a large test file into smaller, focused test cases and updating outdated comments.
- Splits the large
e2e/cases/output/manifest/index.test.tsfile into multiple focused test directories - Creates dedicated directories for each manifest test scenario (basic, filter, generate, etc.)
- Updates outdated comments that incorrectly referenced "main.js" to "index.js"
Reviewed changes
Copilot reviewed 11 out of 35 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| e2e/cases/output/manifest/index.test.ts | Deleted original large test file containing all manifest tests |
| e2e/cases/manifest/basic/* | New test directory for basic manifest generation tests |
| e2e/cases/manifest/filter/* | New test directory for manifest filter functionality tests |
| e2e/cases/manifest/generate/* | New test directory for custom manifest generation tests |
| e2e/cases/manifest/custom-path/* | New test directory for custom manifest path tests |
| e2e/cases/manifest/node/* | New test directory for Node.js target manifest tests |
| e2e/cases/manifest/single-vendor/* | New test directory for single-vendor chunk split manifest tests |
| e2e/cases/manifest/integrity/* | New test directory for manifest integrity/SRI tests |
| e2e/cases/manifest/async-chunks/* | New test directory for async chunk manifest tests |
| e2e/cases/manifest/css-order/* | New test directory for CSS order in manifest tests |
| e2e/cases/manifest/environments/index.test.ts | Updated comments from "main.js" to "index.js" for accuracy |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Reorganize manifest related e2e cases:
manifestfolderChecklist