Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: remove cache in replace source #124

Merged
merged 3 commits into from
Dec 3, 2024
Merged

perf: remove cache in replace source #124

merged 3 commits into from
Dec 3, 2024

Conversation

SyMind
Copy link
Member

@SyMind SyMind commented Dec 3, 2024

No description provided.

@SyMind SyMind marked this pull request as ready for review December 3, 2024 06:51
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Dec 3, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #124 will not alter performance

Comparing SyMind:remove-cache-in-replace-source (b719bb8) with main (f221823)

Summary

✅ 5 untouched benchmarks

@h-a-n-a
Copy link
Collaborator

h-a-n-a commented Dec 3, 2024

Should remove inner_source_code on the struct as well.

@h-a-n-a h-a-n-a merged commit 522657e into web-infra-dev:main Dec 3, 2024
7 checks passed
@SyMind SyMind mentioned this pull request Dec 3, 2024
Merged
2 tasks
@SyMind SyMind deleted the remove-cache-in-replace-source branch December 3, 2024 07:26
@h-a-n-a h-a-n-a mentioned this pull request Dec 4, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@h-a-n-a h-a-n-a h-a-n-a approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SyMind @h-a-n-a