Skip to content

perf: to_writer use utf8 offset and WithIndices use OnceCell #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 8, 2023
Merged

perf: to_writer use utf8 offset and WithIndices use OnceCell #62

merged 2 commits into from
Sep 8, 2023

Conversation

jerrykingxyz
Copy link
Contributor

No description provided.

ahabhgk
ahabhgk approved these changes Sep 5, 2023
View reviewed changes
Copy link
Collaborator

@ahabhgk ahabhgk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just in case, can you open a PR in Rspack repo and use rspack_sources = { git = "https://github.com/web-infra-dev/rspack-sources.git", branch = "jerry/source" } to run ci test and eco-ci test

@jerrykingxyz jerrykingxyz mentioned this pull request Sep 5, 2023
Merged
@ahabhgk ahabhgk merged commit 74c8edd into main Sep 8, 2023
@ahabhgk ahabhgk deleted the jerry/source branch September 8, 2023 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahabhgk ahabhgk ahabhgk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jerrykingxyz @ahabhgk