chore: remove unused vars & prefer const & remove default generic value

crates/node_binding/tests/binding.spec.ts

@@ -1,8 +1,6 @@
-import assert from 'assert'
 import path from 'path'
-import log from 'why-is-node-running'
 import binding from '..'
-import { RawOptions } from '../binding.d'
+import { RawOptions } from '../binding'
 
 describe('binding', () => {
  it('work', async () => {

packages/playground/cases/hooks/asset-emitted/index.test.ts

@@ -5,7 +5,7 @@ test("asset emitted hook should only emit modified assets", async ({
  fileAction,
  rspack
 }) => {
- let assets: string[] = [];
+ const assets: string[] = [];
  rspack.compiler.hooks.assetEmitted.tap("test", function (name) {
  if (name.includes(".hot-update.")) {
  return;
@@ -55,7 +55,7 @@ test("asset emitted should not emit removed assets", async ({
  rspack,
  fileAction
 }) => {
- let assets: string[] = [];
+ const assets: string[] = [];
  rspack.compiler.hooks.assetEmitted.tap("test", function (name) {
  if (name.includes(".hot-update.")) {
  return;

packages/rspack-cli/src/commands/build.ts

@@ -82,7 +82,7 @@ export class BuildCommand implements RspackCommand {
  }
  };
 
- let rspackOptions = { ...options, argv: { ...options } };
+ const rspackOptions = { ...options, argv: { ...options } };
 
  const errorHandler = (err, Stats) => {
  callback(err, Stats);

packages/rspack-cli/src/commands/preview.ts

@@ -40,7 +40,7 @@ export class PreviewCommand implements RspackCommand {
 
  const devServerOptions = config.devServer as DevServer;
 
- let compiler = rspack({ entry: {} });
+ const compiler = rspack({ entry: {} });
  if (!compiler) return;
  try {
  const server = new RspackDevServer(devServerOptions, compiler);

packages/rspack-cli/src/rspack-cli.ts

@@ -14,11 +14,11 @@ import { PreviewCommand } from "./commands/preview";
 import {
  RspackOptions,
  MultiCompiler,
- Compiler,
  rspack,
  MultiRspackOptions,
  Stats,
- MultiStats
+ MultiStats,
+ Compiler
 } from "@rspack/core";
 import { normalizeEnv } from "./utils/options";
 import { loadRspackConfig } from "./utils/loadConfig";
@@ -31,7 +31,7 @@ type Command = "serve" | "build";
 const defaultEntry = "src/index";
 export class RspackCLI {
  colors: RspackCLIColors;
- program: yargs.Argv<{}>;
+ program: yargs.Argv;
  constructor() {
  this.colors = this.createColors();
  this.program = yargs();

packages/rspack-cli/src/utils/loadConfig.ts

@@ -5,7 +5,6 @@ import { RspackOptions, MultiRspackOptions } from "@rspack/core";
 import findConfig from "./findConfig";
 import rechoir from "rechoir";
 import interpret from "interpret";
-import { pathToFileURL } from "url";
 import isEsmFile from "./isEsmFile";
 import isTsFile from "./isTsFile";
 import crossImport from "./crossImport";

packages/rspack-cli/src/utils/options.ts

@@ -1,5 +1,5 @@
 import yargs from "yargs";
-export const commonOptions = (yargs: yargs.Argv<{}>) => {
+export const commonOptions = (yargs: yargs.Argv) => {
  return yargs.options({
  config: {
  g: true,
@@ -40,7 +40,7 @@ export const commonOptions = (yargs: yargs.Argv<{}>) => {
  });
 };
 
-export const previewOptions = (yargs: yargs.Argv<{}>) => {
+export const previewOptions = (yargs: yargs.Argv) => {
  return yargs
  .positional("dir", {
  type: "string",

packages/rspack-cli/src/utils/readPackageUp.ts

@@ -6,7 +6,7 @@ const readPackageUp = (cwd = process.cwd()): { type?: "module" } | null => {
  let packageJsonPath = path.join(currentDir, "package.json");
 
  while (!fs.existsSync(packageJsonPath)) {
- let parentDir = path.dirname(currentDir);
+ const parentDir = path.dirname(currentDir);
  if (parentDir === currentDir) {
  return null;
  }

packages/rspack-cli/tests/build/config/config.test.ts

@@ -1,7 +1,6 @@
 import { run } from "../../utils/test-utils";
-import { writeFileSync, mkdirSync, unlinkSync } from "fs";
-import { rm, readFile } from "fs/promises";
-import { join, resolve } from "path";
+import { readFile } from "fs/promises";
+import { resolve } from "path";
 
 describe("rspack cli", () => {
  describe("should config not found", () => {
@@ -129,13 +128,9 @@ describe("rspack cli", () => {
  describe("should load moonrepo config", () => {
  const cwd = resolve(__dirname, "./moonrepo");
  it("should load moonrepo config.ts file", async () => {
- const { exitCode, stderr, stdout } = await run(
- cwd,
- ["-c", "rspack.config.ts"],
- {
- nodeOptions: ["--experimental-loader=ts-node/esm"]
- }
- );
+ const { exitCode, stdout } = await run(cwd, ["-c", "rspack.config.ts"], {
+ nodeOptions: ["--experimental-loader=ts-node/esm"]
+ });
  expect(stdout).toBeTruthy();
  expect(exitCode).toBe(0);
  expect(

packages/rspack-cli/tests/serve/basic/serve-basic.test.ts

@@ -2,7 +2,7 @@ import { normalizeStderr, runWatch } from "../../utils/test-utils";
 
 describe("basic serve usage", () => {
  it.skip("should work", async () => {
- const { stderr, stdout } = await runWatch(__dirname, ["serve"]);
+ const { stderr } = await runWatch(__dirname, ["serve"]);
 
  // @todo current server implementation is too buggy to test
  expect(normalizeStderr(stderr)).toBeTruthy;

packages/rspack-dev-server/src/middleware.ts

@@ -32,7 +32,7 @@ export function getRspackMemoryAssets(
  const filename = path.startsWith(publicPath)
  ? path.slice(publicPath.length)
  : path.slice(1);
- let buffer =
+ const buffer =
  compiler.getAsset(filename) ??
  (() => {
  const { index } = rdm.context.options;

packages/rspack-dev-server/src/server.ts

@@ -445,7 +445,7 @@ export class RspackDevServer extends WebpackDevServer {
  compilers.forEach(compiler => {
  if (compiler.options.experiments.lazyCompilation) {
  middlewares.push({
- middleware: (req, res, next) => {
+ middleware: (req, res) => {
  if (req.url.indexOf("/lazy-compilation-web/") > -1) {
  const path = req.url.replace("/lazy-compilation-web/", "");
  if (fs.existsSync(path)) {

packages/rspack/src/Compilation.ts

@@ -121,7 +121,7 @@ export class Compilation {
  this.name = undefined;
  this.startTime = undefined;
  this.endTime = undefined;
- let processAssetsHooks = createFakeProcessAssetsHook(this);
+ const processAssetsHooks = createFakeProcessAssetsHook(this);
  this.hooks = {
  processAssets: processAssetsHooks,
  // TODO: webpack 6 deprecate, keep it just for compatibility
@@ -178,7 +178,7 @@ export class Compilation {
  return this.__internal__getAssetSource(property);
  }
  },
- set: (target, p, newValue, receiver) => {
+ set: (target, p, newValue) => {
  if (typeof p === "string") {
  this.__internal__setAssetSource(p, newValue);
  return true;
@@ -437,12 +437,12 @@ export class Compilation {
  }
 
  get errors() {
- let inner = this.#inner;
+ const inner = this.#inner;
  return {
  push: (...errs: (Error | JsStatsError)[]) => {
  // compatible for javascript array
  for (let i = 0; i < errs.length; i++) {
- let error = errs[i];
+ const error = errs[i];
  this.#inner.pushDiagnostic(
  "error",
  isJsStatsError(error) ? error.title : error.name,
@@ -452,7 +452,7 @@ export class Compilation {
  },
  [Symbol.iterator]() {
  // TODO: this is obviously a bad design, optimize this after finishing angular prototype
- let errors = inner.getStats().getErrors();
+ const errors = inner.getStats().getErrors();
  let index = 0;
  return {
  next() {
@@ -470,14 +470,14 @@ export class Compilation {
  }
 
  get warnings() {
- let inner = this.#inner;
+ const inner = this.#inner;
  return {
  // compatible for javascript array
  push: (...warns: (Error | JsStatsError)[]) => {
  // TODO: find a way to make JsStatsError be actual errors
  warns = this.hooks.processWarnings.call(warns as any);
  for (let i = 0; i < warns.length; i++) {
- let warn = warns[i];
+ const warn = warns[i];
  this.#inner.pushDiagnostic(
  "warning",
  isJsStatsError(warn) ? warn.title : warn.name,
@@ -487,7 +487,7 @@ export class Compilation {
  },
  [Symbol.iterator]() {
  // TODO: this is obviously a bad design, optimize this after finishing angular prototype
- let warnings = inner.getStats().getWarnings();
+ const warnings = inner.getStats().getWarnings();
  let index = 0;
  return {
  next() {
@@ -656,7 +656,7 @@ export class Compilation {
 
  // FIXME: This is not aligned with Webpack.
  get chunks() {
- var stats = this.getStats().toJson({
+ const stats = this.getStats().toJson({
  all: false,
  chunks: true,
  chunkModules: true,
@@ -683,13 +683,13 @@ export class Compilation {
  * @internal
  */
  __internal__getAssociatedModules(chunk: JsStatsChunk): any[] | undefined {
- let modules = this.__internal__getModules();
- let moduleMap: Map<string, JsModule> = new Map();
- for (let module of modules) {
+ const modules = this.__internal__getModules();
+ const moduleMap: Map<string, JsModule> = new Map();
+ for (const module of modules) {
  moduleMap.set(module.moduleIdentifier, module);
  }
  return chunk.modules?.flatMap(chunkModule => {
- let jsModule = this.__internal__findJsModule(
+ const jsModule = this.__internal__findJsModule(
  chunkModule.issuer ?? chunkModule.identifier,
  moduleMap
  );

packages/rspack/src/Compiler.ts

@@ -24,7 +24,7 @@ import { Stats } from "./Stats";
 import { Compilation, CompilationParams } from "./Compilation";
 import { ContextModuleFactory } from "./ContextModuleFactory";
 import ResolverFactory from "./ResolverFactory";
-import { getRawOptions } from "./config/adapter";
+import { getRawOptions } from "./config";
 import { LoaderContext, LoaderResult } from "./config/adapterRuleUse";
 import ConcurrentCompilationError from "./error/ConcurrentCompilationError";
 import { createThreadsafeNodeFSFromRaw } from "./fileSystem";

packages/rspack/src/MultiCompiler.ts

@@ -8,31 +8,23 @@
  * https://github.com/webpack/webpack/blob/main/LICENSE
  */
 
-import {
- Compilation,
- Compiler,
- RspackOptions,
- RspackOptionsNormalized,
- Stats
-} from ".";
+import { Compiler, RspackOptions, Stats } from ".";
 import ResolverFactory from "./ResolverFactory";
 import { WatchFileSystem } from "./util/fs";
 import Watching from "./Watching";
-import tapable, {
+import {
  AsyncSeriesHook,
  Callback,
  MultiHook,
- SyncHook
+ SyncHook,
+ SyncBailHook
 } from "tapable";
 import MultiStats from "./MultiStats";
 import asyncLib from "neo-async";
 import ArrayQueue from "./util/ArrayQueue";
 import ConcurrentCompilationError from "./error/ConcurrentCompilationError";
 import MultiWatching from "./MultiWatching";
 import { WatchOptions } from "./config";
-import { IFs } from "memfs";
-import assert from "assert";
-import { isNil } from "./util";
 
 type Any = any;
 

packages/rspack/src/MultiStats.ts

@@ -9,7 +9,6 @@
  */
 
 import { KnownCreateStatsOptionsContext } from ".";
-import { SnapshotOptions } from "./config";
 import { StatsCompilation } from "./stats/statsFactoryUtils";
 import { Stats } from "./Stats";
 import { indent } from "./util";

packages/rspack/src/builtin-plugin/index.ts

@@ -21,7 +21,7 @@ import {
  RawBuiltins,
  RawCssModulesConfig
 } from "@rspack/binding";
-import { termlink, deprecatedWarn } from "../util";
+import { deprecatedWarn } from "../util";
 import { Compiler, RspackOptionsNormalized } from "..";
 import {
  HtmlPluginOptions,
@@ -35,8 +35,7 @@ import {
  CopyPlugin,
  BannerPlugin,
  SwcJsMinimizerPlugin,
- SwcCssMinimizerPlugin,
- RspackBuiltinPlugin
+ SwcCssMinimizerPlugin
 } from ".";
 import { loadConfig } from "browserslist";
 import path from "path";

packages/rspack/src/config/adapterRuleUse.ts

@@ -4,7 +4,6 @@ import type {
  RawModuleRuleUse,
  RawOptions
 } from "@rspack/binding";
-import assert from "assert";
 import { ResolveRequest } from "enhanced-resolve";
 
 import { Compiler } from "../Compiler";
@@ -13,7 +12,6 @@ import Hash from "../util/hash";
 import {
  Mode,
  Resolve,
- RuleSetUse,
  RuleSetUseItem,
  RuleSetLoaderWithOptions
 } from "./types";

packages/rspack/src/config/defaults.ts

@@ -13,7 +13,6 @@ import fs from "fs";
 import path from "path";
 import { isNil } from "../util";
 import { cleverMerge } from "../util/cleverMerge";
-import { deprecated_resolveBuiltins } from "../builtin-plugin";
 import {
  getDefaultTarget,
  getTargetProperties,
@@ -22,8 +21,6 @@ import {
 import type {
  AvailableTarget,
  Context,
- Entry,
- EntryDescription,
  EntryDescriptionNormalized,
  EntryNormalized,
  ExperimentsNormalized,
@@ -653,7 +650,7 @@ const applyNodeDefaults = (
 
 const applyOptimizationDefaults = (
  optimization: Optimization,
- { production, development }: { production: boolean; development: boolean }
+ { production }: { production: boolean; development: boolean }
 ) => {
  D(optimization, "removeAvailableModules", true);
  D(optimization, "removeEmptyChunks", true);

packages/rspack/src/config/normalization.ts

@@ -13,7 +13,6 @@ import type {
  EntryStatic,
  EntryStaticNormalized,
  LibraryOptions,
- OptimizationRuntimeChunk,
  OptimizationRuntimeChunkNormalized,
  RspackOptions,
  RspackOptionsNormalized

packages/rspack/src/config/zod/optimization/index.ts

@@ -1,5 +1,4 @@
 import { z } from "zod";
-import { Compiler } from "../../../Compiler";
 import { splitChunks } from "./split-chunks";
 
 const rspackPluginInstance = z.any();