Skip to content

Commit

Permalink
chore: remove unnecessary code (#8641)
Browse files Browse the repository at this point in the history
  • Loading branch information
shulaoda authored Dec 9, 2024
1 parent 8646ecf commit 1d661ff
Showing 1 changed file with 0 additions and 27 deletions.
27 changes: 0 additions & 27 deletions crates/rspack_plugin_javascript/src/parser_and_generator/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -247,33 +247,6 @@ impl ParserAndGenerator for JavaScriptParserAndGenerator {
});
}

// let inner_graph = if compiler_options.optimization.inner_graph {
// ast.transform(|program, context| {
// let unresolved_ctxt = SyntaxContext::empty().apply_mark(context.unresolved_mark);
// let top_level_ctxt = SyntaxContext::empty().apply_mark(context.top_level_mark);
// let mut plugin = InnerGraphPlugin::new(
// &mut dependencies,
// unresolved_ctxt,
// top_level_ctxt,
// &mut usage_span_record,
// &import_map,
// module_identifier,
// program.comments.take(),
// &path_ignored_spans,
// );
// plugin.enable();
// // program.visit_with(&mut plugin);
// program.comments = plugin.comments.take();
// Some(plugin)
// })
// } else {
// None
// };

// if let Some(mut inner_graph) = inner_graph {
// inner_graph.infer_dependency_usage();
// }

Ok(
ParseResult {
source,
Expand Down

2 comments on commit 1d661ff

@rspack-bot
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 Benchmark detail: Open

Name Base (2024-12-09 8646ecf) Current Change
10000_big_production-mode_disable-minimize + exec 37.1 s ± 157 ms 37.2 s ± 406 ms +0.02 %
10000_development-mode + exec 1.79 s ± 24 ms 1.79 s ± 23 ms -0.13 %
10000_development-mode_hmr + exec 648 ms ± 16 ms 641 ms ± 6.3 ms -1.08 %
10000_production-mode + exec 2.34 s ± 25 ms 2.34 s ± 59 ms +0.12 %
arco-pro_development-mode + exec 1.77 s ± 83 ms 1.76 s ± 64 ms -0.97 %
arco-pro_development-mode_hmr + exec 424 ms ± 1.3 ms 424 ms ± 0.94 ms +0.03 %
arco-pro_production-mode + exec 3.15 s ± 86 ms 3.13 s ± 62 ms -0.69 %
arco-pro_production-mode_generate-package-json-webpack-plugin + exec 3.14 s ± 78 ms 3.17 s ± 82 ms +0.99 %
threejs_development-mode_10x + exec 1.62 s ± 29 ms 1.62 s ± 12 ms -0.25 %
threejs_development-mode_10x_hmr + exec 781 ms ± 11 ms 787 ms ± 7.9 ms +0.74 %
threejs_production-mode_10x + exec 4.86 s ± 38 ms 4.88 s ± 18 ms +0.27 %
10000_big_production-mode_disable-minimize + rss memory 9774 MiB ± 22.1 MiB 9800 MiB ± 41.6 MiB +0.26 %
10000_development-mode + rss memory 815 MiB ± 36 MiB 820 MiB ± 33.2 MiB +0.59 %
10000_development-mode_hmr + rss memory 2094 MiB ± 254 MiB 2048 MiB ± 291 MiB -2.19 %
10000_production-mode + rss memory 696 MiB ± 26.9 MiB 694 MiB ± 29.5 MiB -0.29 %
arco-pro_development-mode + rss memory 718 MiB ± 28.2 MiB 719 MiB ± 33.3 MiB +0.15 %
arco-pro_development-mode_hmr + rss memory 914 MiB ± 105 MiB 914 MiB ± 62.1 MiB +0.02 %
arco-pro_production-mode + rss memory 785 MiB ± 48.6 MiB 810 MiB ± 77.8 MiB +3.19 %
arco-pro_production-mode_generate-package-json-webpack-plugin + rss memory 814 MiB ± 50.1 MiB 829 MiB ± 49 MiB +1.88 %
threejs_development-mode_10x + rss memory 789 MiB ± 45.3 MiB 759 MiB ± 38.1 MiB -3.81 %
threejs_development-mode_10x_hmr + rss memory 1728 MiB ± 255 MiB 1749 MiB ± 154 MiB +1.26 %
threejs_production-mode_10x + rss memory 1146 MiB ± 82.1 MiB 1090 MiB ± 44 MiB -4.90 %

@rspack-bot
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 Ran ecosystem CI: Open

suite result
modernjs ✅ success
_selftest ✅ success
rsdoctor ✅ success
rspress ✅ success
rslib ✅ success
rsbuild ✅ success
examples ✅ success
devserver ✅ success
nuxt ✅ success

Please sign in to comment.