Skip to content

Commit

Permalink
fix(ci): pkg.pr.preview not work (#8325)
Browse files Browse the repository at this point in the history 
* fix(ci): pkg

* Update .github/workflows/ci.yml

Co-authored-by: neverland <chenjiahan.jait@bytedance.com>

---------

Co-authored-by: neverland <chenjiahan.jait@bytedance.com>
  • Loading branch information
@SoonIter @chenjiahan
SoonIter and chenjiahan authored Nov 4, 2024
1 parent b89df1d commit 2e89bca
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 2 deletions.
1 change: 1 addition & 0 deletions .github/workflows/ci.yml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -398,5 +398,6 @@ jobs:
- lint
- rust_check
- rust_test
# after merged to main branch
if: ${{ !failure() && github.event_name == 'push' }}
uses: ./.github/workflows/preview-commit.yml
2 changes: 1 addition & 1 deletion .github/workflows/preview-commit.yml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ jobs:
- target: x86_64-unknown-linux-gnu
runner: ${{ needs.get-runner-labels.outputs.LINUX_RUNNER_LABELS }}
- target: aarch64-unknown-linux-gnu
runner: ubuntu-latest
runner: "'ubuntu-latest'"
- target: x86_64-unknown-linux-musl
runner: ${{ needs.get-runner-labels.outputs.LINUX_RUNNER_LABELS }}
- target: aarch64-unknown-linux-musl
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@
"test:webpack": "pnpm --filter \"webpack-test\" test:metric",
"doc-coverage": "pnpm --filter \"@rspack/core\" doc-coverage",
"api-extractor:local": "pnpm --filter \"@rspack/*\" api-extractor --local",
"api-extractor:ci": "pnpm --filter \"'@rspack/*\" api-extractor:ci"
"api-extractor:ci": "pnpm --filter \"@rspack/*\" api-extractor:ci"
},
"homepage": "https://rspack.dev",
"bugs": "https://github.com/web-infra-dev/rspack/issues",
Expand Down

2 comments on commit 2e89bca

@rspack-bot
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 Benchmark detail: Open

Name Base (2024-11-04 a987332) Current Change
10000_big_production-mode + exec 45.9 s ± 613 ms 44.4 s ± 1.11 s -3.23 %
10000_development-mode + exec 1.84 s ± 17 ms 1.84 s ± 17 ms -0.03 %
10000_development-mode_hmr + exec 645 ms ± 12 ms 644 ms ± 7.5 ms -0.17 %
10000_production-mode + exec 2.4 s ± 19 ms 2.44 s ± 47 ms +1.85 %
arco-pro_development-mode + exec 1.79 s ± 63 ms 1.76 s ± 54 ms -1.37 %
arco-pro_development-mode_hmr + exec 429 ms ± 1.2 ms 431 ms ± 2 ms +0.47 %
arco-pro_production-mode + exec 3.19 s ± 87 ms 3.2 s ± 107 ms +0.47 %
arco-pro_production-mode_generate-package-json-webpack-plugin + exec 3.27 s ± 50 ms 3.27 s ± 68 ms +0.16 %
threejs_development-mode_10x + exec 1.58 s ± 7.7 ms 1.57 s ± 14 ms -0.47 %
threejs_development-mode_10x_hmr + exec 784 ms ± 4.2 ms 775 ms ± 12 ms -1.19 %
threejs_production-mode_10x + exec 4.93 s ± 40 ms 4.95 s ± 19 ms +0.35 %

@rspack-bot
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 Ran ecosystem CI: Open

suite result
modernjs ❌ failure
_selftest ✅ success
rspress ✅ success
rslib ✅ success
rsbuild ❌ failure
examples ❌ failure
devserver ✅ success

Please sign in to comment.