test: delete test.filter.js if test is pass in tests/webpack-test (#8409

)

* test: delete test.filter.js if test is pass in tests/webpack-test

* test: add test.filter.js for watchCases/parsing/switching-harmony

crates/rspack_core/src/old_cache/local/code_splitting_cache.rs

@@ -7,7 +7,7 @@ use tracing::instrument;
 
 use crate::{
   build_chunk_graph::code_splitter::CodeSplitter, incremental::IncrementalPasses, Chunk,
-  ChunkGraph, ChunkGroup, ChunkGroupUkey, ChunkUkey, Compilation,
+  ChunkGraph, ChunkGroup, ChunkGroupUkey, ChunkUkey, Compilation, ModuleIdentifier,
 };
 
 #[derive(Debug, Default)]
@@ -20,6 +20,7 @@ pub struct CodeSplittingCache {
   named_chunk_groups: HashMap<String, ChunkGroupUkey>,
   named_chunks: HashMap<String, ChunkUkey>,
   pub(crate) code_splitter: CodeSplitter,
+  pub(crate) module_idx: HashMap<ModuleIdentifier, (u32, u32)>,
 }
 
 #[instrument(skip_all)]
@@ -56,6 +57,17 @@ where
       s.spawn(|_| compilation.named_chunks = cache.named_chunks.clone());
     });
 
+    let module_idx = cache.module_idx.clone();
+    let mut module_graph = compilation.get_module_graph_mut();
+    for (m, (pre, post)) in module_idx {
+      let Some(mgm) = module_graph.module_graph_module_by_identifier_mut(&m) else {
+        continue;
+      };
+
+      mgm.pre_order_index = Some(pre);
+      mgm.post_order_index = Some(post);
+    }
+
     if !has_change {
       return Ok(());
     }
@@ -72,5 +84,21 @@ where
     s.spawn(|_| cache.named_chunk_groups = compilation.named_chunk_groups.clone());
     s.spawn(|_| cache.named_chunks = compilation.named_chunks.clone());
   });
+
+  let mg = compilation.get_module_graph();
+  let mut map = HashMap::default();
+  for m in mg.modules().keys() {
+    let Some(mgm) = mg.module_graph_module_by_identifier(m) else {
+      continue;
+    };
+
+    let (Some(pre), Some(post)) = (mgm.pre_order_index, mgm.post_order_index) else {
+      continue;
+    };
+
+    map.insert(*m, (pre, post));
+  }
+  let cache = &mut compilation.code_splitting_cache;
+  cache.module_idx = map;
   Ok(())
 }

crates/rspack_ids/src/deterministic_module_ids_plugin.rs

@@ -36,9 +36,7 @@ fn module_ids(&self, compilation: &mut Compilation) -> Result<()> {
     |m| get_full_module_name(m, context),
     |a, b| compare_modules_by_pre_order_index_or_identifier(&module_graph, a, b),
     |module, id| {
-      let size = used_ids.len();
-      used_ids.insert(id.to_string());
-      if used_ids.len() == size {
+      if !used_ids.insert(id.to_string()) {
         conflicts += 1;
         return false;
       }

packages/rspack-test-tools/tests/watchCases/split-chunks-incremental/pre-order-index/0/index.js

@@ -0,0 +1,5 @@
+import v from './lib'
+
+it('should compile', async () => {
+	expect(v).toBe(1)
+})

packages/rspack-test-tools/tests/watchCases/split-chunks-incremental/pre-order-index/0/lib.js

@@ -0,0 +1 @@
+export default 1;

packages/rspack-test-tools/tests/watchCases/split-chunks-incremental/pre-order-index/1/lib.js

@@ -0,0 +1,2 @@
+// change
+export default 1;

packages/rspack-test-tools/tests/watchCases/split-chunks-incremental/pre-order-index/rspack.config.js

@@ -0,0 +1,6 @@
+/** @type {import("@rspack/core").Configuration} */
+module.exports = {
+	optimization: {
+		splitChunks: false,
+	},
+};

packages/rspack-test-tools/tests/watchCases/split-chunks-incremental/pre-order-index/test.config.js

@@ -0,0 +1,10 @@
+module.exports = {
+	checkStats(_stepName, stats) {
+		// should keep module preOrderIndex and postOrderIndex during build
+		return [...stats.modules].filter(m => {
+			return m.moduleType !== 'runtime'
+		}).every((m) => {
+			return m.preOrderIndex !== undefined && m.postOrderIndex !== undefined
+		})
+	}
+}

tests/webpack-test/cases/large/many-replacements/test.filter.js

@@ -2,4 +2,5 @@
 // 	return !process.env.CI;
 // };
 
+// TODO: Should create a issue for this test
 module.exports = () => false // passed it, but it's too slow

tests/webpack-test/cases/parsing/optional-catch-binding/test.filter.js

@@ -1,11 +1,10 @@
 
 const supportsOptionalCatchBinding = require("../../../helpers/supportsOptionalCatchBinding");
 
-module.exports = function(config) {
+module.exports = function (config) {
 	// XXX: Disable this test if Terser is used because it does not support ES 2019
 	if (config.mode === "production") {
 		return false;
 	}
 	return supportsOptionalCatchBinding();
 };
-

tests/webpack-test/cases/wasm/v128/test.filter.js

@@ -1,6 +1,7 @@
 const supportsWebAssembly = require("../../../helpers/supportsWebAssembly");
 const supportsFeature = require("webassembly-feature");
 
+// TODO: Should create a issue for this test
 module.exports = function (config) {
 	// CompileError: WebAssembly.instantiate(): Compiling function #0 failed: memory instruction with no memory @+27
 	return false

tests/webpack-test/configCases/additional-pass/simple/test.filter.js

@@ -1 +1,2 @@
-module.exports = () => {return false}
+// TODO: Should create a issue for this test
+module.exports = () => { return false }

tests/webpack-test/configCases/asset-emitted/normal/test.filter.js

@@ -1 +1,2 @@
-module.exports = () => {return false}
+// TODO: Should create a issue for this test
+module.exports = () => { return false }

tests/webpack-test/configCases/asset-modules/custom-condition/test.filter.js

@@ -1 +1,2 @@
-module.exports = () => {return false}
+// TODO: Should create a issue for this test
+module.exports = () => { return false }

tests/webpack-test/configCases/asset-modules/file-url/test.filter.js

@@ -1 +1,2 @@
-module.exports = () => {return false}
+// TODO: Should create a issue for this test
+module.exports = () => { return false }

tests/webpack-test/configCases/asset-modules/global-options/test.filter.js

@@ -1 +1,2 @@
-module.exports = () => {return false}
+// TODO: Should create a issue for this test
+module.exports = () => { return false }

tests/webpack-test/configCases/asset-modules/http-url/test.filter.js

@@ -1 +1,2 @@
-module.exports = () => {return false}
+// TODO: Should create a issue for this test
+module.exports = () => { return false }

tests/webpack-test/configCases/asset-modules/ignore/test.filter.js

@@ -1 +1,2 @@
-module.exports = () => {return false}
+// TODO: Should create a issue for this test
+module.exports = () => { return false }

tests/webpack-test/configCases/asset-modules/input-data-url-encoding/test.filter.js

@@ -1 +1,2 @@
-module.exports = () => {return false}
+// TODO: Should create a issue for this test
+module.exports = () => { return false }

tests/webpack-test/configCases/asset-modules/query-and-custom-condition/test.filter.js

@@ -1 +1,2 @@
-module.exports = () => {return false}
+// TODO: Should create a issue for this test
+module.exports = () => { return false }

tests/webpack-test/configCases/asset-modules/query-and-custom-encoder/test.filter.js

@@ -1 +1,2 @@
-module.exports = () => {return false}
+// TODO: Should create a issue for this test
+module.exports = () => { return false }

tests/webpack-test/configCases/asset-modules/real-content-hash/test.filter.js

@@ -1 +1,2 @@
-module.exports = () => {return false}
+// TODO: Should create a issue for this test
+module.exports = () => { return false }

tests/webpack-test/configCases/asset-modules/rule-generator-outputPath/test.filter.js

@@ -1 +1,2 @@
-module.exports = () => {return false}
+// TODO: Should create a issue for this test
+module.exports = () => { return false }

tests/webpack-test/configCases/asset-modules/unsafe-cache-13827/test.filter.js

@@ -1 +1,2 @@
-module.exports = () => {return false}
+// TODO: Should create a issue for this test
+module.exports = () => { return false }

tests/webpack-test/configCases/asset-url/target-node3/test.filter.js

@@ -1 +1,2 @@
-module.exports = () => {return false}
+// TODO: Should create a issue for this test
+module.exports = () => { return false }

tests/webpack-test/configCases/asset-url/target-web1/test.filter.js

@@ -1 +1,2 @@
-module.exports = () => {return false}
+// TODO: Should create a issue for this test
+module.exports = () => { return false }

tests/webpack-test/configCases/chunk-index/order-multiple-entries/test.filter.js

@@ -1,4 +1,5 @@
 // enable when support compilation.moduleGraph(unimplemented).getPreOrderIndex(unimplemented)
+// TODO: Should create a issue for this test
 module.exports = () => {
 	return false;
 };

tests/webpack-test/configCases/clean/dry/test.filter.js

@@ -1 +1,2 @@
-module.exports = () => {return false}
+// TODO: Should create a issue for this test
+module.exports = () => { return false }

tests/webpack-test/configCases/clean/ignore-fn/test.filter.js

@@ -1 +1,2 @@
-module.exports = () => {return false}
+// TODO: Should create a issue for this test
+module.exports = () => { return false }

tests/webpack-test/configCases/clean/ignore-hook/test.filter.js

@@ -1 +1,2 @@
-module.exports = () => {return false}
+// TODO: Should create a issue for this test
+module.exports = () => { return false }

tests/webpack-test/configCases/clean/ignore-rx/test.filter.js

@@ -1 +1,2 @@
-module.exports = () => {return false}
+// TODO: Should create a issue for this test
+module.exports = () => { return false }

tests/webpack-test/configCases/clean/link/test.filter.js

@@ -16,4 +16,5 @@
 // 	}
 // };
 
-module.exports = () => {return false}
+// TODO: Should create a issue for this test
+module.exports = () => { return false }

tests/webpack-test/configCases/code-generation/require-context-id/test.filter.js

@@ -1 +1,2 @@
-module.exports = () => {return false}
+// TODO: Should create a issue for this test
+module.exports = () => { return false }

tests/webpack-test/configCases/code-generation/use-strict/test.filter.js

@@ -1 +1,2 @@
-module.exports = () => {return false}
+// TODO: Should create a issue for this test
+module.exports = () => { return false }

tests/webpack-test/configCases/concatenate-modules/import-module/test.filter.js

@@ -1,3 +1,5 @@
+// TODO: Should create a issue for this test
+// TODO: This test would painic, we should not painic when build
 module.exports = () => {
 	return false;
 };

tests/webpack-test/configCases/concatenate-modules/split-chunk-entry-module/test.filter.js

@@ -1 +1,2 @@
-module.exports = () => {return false}
+// TODO: Should create a issue for this test
+module.exports = () => { return false }

tests/webpack-test/configCases/contenthash/assets/test.filter.js

@@ -1,2 +1,3 @@
 // blocked by https://github.com/web-infra-dev/rspack/issues/3465
-module.exports = () => {return false}
+// TODO: Should create a issue for this test
+module.exports = () => { return false }

tests/webpack-test/configCases/contenthash/include-chunk-id/test.filter.js

@@ -1,2 +1,3 @@
 // blocked by chunkIds
-module.exports = () => {return false}
+// TODO: Should create a issue for this test
+module.exports = () => { return false }

tests/webpack-test/configCases/context-exclusion/simple/test.filter.js

@@ -1 +1,2 @@
-module.exports = () => {return false}
+// TODO: Should create a issue for this test
+module.exports = () => { return false }

tests/webpack-test/configCases/context-replacement/a/test.filter.js

@@ -1 +1,2 @@
-module.exports = () => { return false }
+// TODO: Should create a issue for this test
+module.exports = () => { return false }

tests/webpack-test/configCases/context-replacement/c/test.filter.js

@@ -1 +1,2 @@
-module.exports = () => {return false}
+// TODO: Should create a issue for this test
+module.exports = () => { return false }

tests/webpack-test/configCases/context-replacement/d/test.filter.js

@@ -1 +1,2 @@
-module.exports = () => {return false}
+// TODO: Should create a issue for this test
+module.exports = () => { return false }

tests/webpack-test/configCases/context-replacement/e/test.filter.js

@@ -1 +1,2 @@
-module.exports = () => {return false}
+// TODO: Should create a issue for this test
+module.exports = () => { return false }

tests/webpack-test/configCases/css/css-modules-in-node/test.filter.js

@@ -1,2 +1,3 @@
 // do not support webpack.ids.DeterministicModuleIdsPlugin
+// TODO: Should create a issue for this test
 module.exports = () => false;

tests/webpack-test/configCases/css/css-modules/test.filter.js

@@ -1,2 +1,3 @@
 // do not support webpack.ids.DeterministicModuleIdsPlugin
+// TODO: Should create a issue for this test
 module.exports = () => false;

tests/webpack-test/configCases/css/urls/test.filter.js

@@ -1 +1,2 @@
+// TODO: Should create a issue for this test
 module.exports = () => false;

tests/webpack-test/configCases/custom-modules/json-custom/test.filter.js

@@ -1 +1,2 @@
-module.exports = () => {return false}
+// TODO: Should create a issue for this test
+module.exports = () => { return false }

tests/webpack-test/configCases/custom-source-type/localization/test.filter.js

@@ -1 +1,2 @@
-module.exports = () => {return false}
+// TODO: Should create a issue for this test
+module.exports = () => { return false }

tests/webpack-test/configCases/deep-scope-analysis/remove-export-scope-hoisting/test.filter.js

@@ -1 +1,2 @@
-module.exports = () => {return false}
+// TODO: Should create a issue for this test
+module.exports = () => { return false }

tests/webpack-test/configCases/deep-scope-analysis/remove-export/test.filter.js

@@ -1 +1,2 @@
-module.exports = () => {return false}
+// TODO: Should create a issue for this test
+module.exports = () => { return false }

tests/webpack-test/configCases/delegated-hash/simple/test.filter.js

@@ -1 +1,2 @@
-module.exports = () => {return false}
+// TODO: Should create a issue for this test
+module.exports = () => { return false }

tests/webpack-test/configCases/delegated/simple/test.filter.js

@@ -1 +1,2 @@
-module.exports = () => {return false}
+// TODO: Should create a issue for this test
+module.exports = () => { return false }

tests/webpack-test/configCases/deprecations/chunk-and-module/test.filter.js

@@ -1 +1,2 @@
-module.exports = () => {return false}
+// TODO: Should create a issue for this test
+module.exports = () => { return false }

tests/webpack-test/configCases/deprecations/chunk-files/test.filter.js

@@ -1 +1,2 @@
-module.exports = () => {return false}
+// TODO: Should create a issue for this test
+module.exports = () => { return false }

tests/webpack-test/configCases/deprecations/config/test.filter.js

@@ -1 +1,2 @@
-module.exports = () => {return false}
+// TODO: Should create a issue for this test
+module.exports = () => { return false }

tests/webpack-test/configCases/deprecations/invalid-dependencies/test.filter.js

@@ -1 +1,2 @@
-module.exports = () => {return false}
+// TODO: Should create a issue for this test
+module.exports = () => { return false }