fix: correct split-chunks tests

packages/rspack-test-tools/etc/test-tools.api.md

@@ -1462,6 +1462,7 @@ export type TTestConfig<T extends ECompilerType> = {
     beforeExecute?: () => void;
     afterExecute?: () => void;
     moduleScope?: (ms: IBasicModuleScope, stats?: TCompilerStatsCompilation<T>) => IBasicModuleScope;
+    checkStats?: (stepName: string, stats: TCompilerStatsCompilation<T>) => boolean;
     findBundle?: (index: number, options: TCompilerOptions<T>) => string | string[];
     bundlePath?: string[];
     nonEsmThis?: (p: string | string[]) => Object;

packages/rspack-test-tools/src/helper/util/checkStats.js

@@ -9,8 +9,10 @@ exports.checkChunkModules = function checkChunkModules(
 
 		const expectedModules = chunkModulesMap[chunkId];
 		const chunkModules = chunk.modules.map(m => m.identifier);
-		if (strict) {
-			expectedModules.length === chunkModules.length;
+		if (strict && expectedModules.length !== chunkModules.length) {
+			throw new Error(
+				`expect chunk ${chunkId} has ${chunkModules.length} modules: ${chunkModules}\nbut received ${chunkModules.length} modules`
+			);
 		}
 
 		for (const module of expectedModules) {

packages/rspack-test-tools/src/processor/watch.ts

@@ -95,6 +95,8 @@ export class WatchProcessor<
 		const warnings: Array<{ message: string; stack?: string }> = [];
 		const compiler = this.getCompiler(context);
 		const stats = compiler.getStats();
+		const checkStats = testConfig.checkStats || (() => true);
+
 		if (stats) {
 			fs.writeFileSync(
 				path.join(context.getDist(), "stats.txt"),
@@ -107,6 +109,10 @@ export class WatchProcessor<
 			const jsonStats = stats.toJson({
 				errorDetails: true
 			});
+
+			if (!checkStats(this._watchOptions.stepName, jsonStats)) {
+				throw new Error("stats check failed");
+			}
 			fs.writeFileSync(
 				path.join(context.getDist(), "stats.json"),
 				JSON.stringify(jsonStats, null, 2),

packages/rspack-test-tools/src/type.ts

@@ -195,6 +195,10 @@ export type TTestConfig<T extends ECompilerType> = {
 		ms: IBasicModuleScope,
 		stats?: TCompilerStatsCompilation<T>
 	) => IBasicModuleScope;
+	checkStats?: (
+		stepName: string,
+		stats: TCompilerStatsCompilation<T>
+	) => boolean;
 	findBundle?: (
 		index: number,
 		options: TCompilerOptions<T>

packages/rspack-test-tools/tests/watchCases/split-chunks-incremental/available-modules-change/0/index.js

@@ -1,24 +1,8 @@
-const { checkChunkModules } = __non_webpack_require__("@rspack/test-tools");
-
 it('should compile', async () => {
 	const [v1, v2] = await Promise.all([
 		import('./dyn-1').then(m => m.default),
 		import('./dyn-2').then(m => m.default)
 	])
 	expect(v1.default).toBe('shared')
 	expect(v2.default).toBe('shared')
-
-	checkChunkModules(STATS_JSON, {
-		'dyn-1': [
-			'dyn-1.js',
-			'm.js'
-		],
-		'dyn-2': [
-			'dyn-2.js',
-		],
-		shared: [
-			'shared.js',
-			'm.js',
-		]
-	})
 })

packages/rspack-test-tools/tests/watchCases/split-chunks-incremental/available-modules-change/test.config.js

@@ -0,0 +1,42 @@
+const { checkChunkModules } = require("@rspack/test-tools");
+
+module.exports = {
+	checkStats(stepName, stats) {
+		switch (stepName) {
+			case '0':
+				checkChunkModules(stats, {
+					'dyn-1': [
+						'dyn-1.js',
+						'm.js'
+					],
+					'dyn-2': [
+						'dyn-2.js',
+					],
+					shared: [
+						'shared.js',
+						'm.js',
+					]
+				})
+				break
+			case '1':
+				checkChunkModules(stats, {
+					'dyn-1': [
+						'dyn-1.js',
+						'm.js'
+					],
+					'dyn-2': [
+						'dyn-2.js',
+						'm.js'
+					],
+					shared: [
+						'shared.js',
+					]
+				})
+				break;
+			default:
+				throw "no have more step"
+		}
+
+		return true
+	}
+}

packages/rspack-test-tools/tests/watchCases/split-chunks-incremental/basic/1/m.js

@@ -1 +1 @@
-export default 'v';
+export default 1;

packages/rspack-test-tools/tests/watchCases/split-chunks-incremental/chunk-add-then-change-ava-module/0/index.js

@@ -3,14 +3,4 @@ const { checkChunkModules } = __non_webpack_require__("@rspack/test-tools");
 it('should compile', async () => {
 	const v1 = await import('./dyn-1').then(m => m.default)
 	expect(v1.default).toBe('shared')
-
-	checkChunkModules(STATS_JSON, {
-		'dyn-1': [
-			'dyn-1.js',
-			'm.js',
-		],
-		shared: [
-			'shared.js',
-		]
-	})
 })

packages/rspack-test-tools/tests/watchCases/split-chunks-incremental/chunk-add-then-change-ava-module/1/index.js

@@ -8,17 +8,5 @@ it('should compile', async () => {
 	expect(v1.default).toBe('shared')
 	expect(v2.default).toBe('shared')
 
-	checkChunkModules(STATS_JSON, {
-		'dyn-1': [
-			'dyn-1.js',
-			'm.js'
-		],
-		'dyn-2': [
-			'dyn-2.js',
-		],
-		shared: [
-			'shared.js',
-			'm.js'
-		]
-	})
+
 })

packages/rspack-test-tools/tests/watchCases/split-chunks-incremental/chunk-add-then-change-ava-module/test.config.js

@@ -0,0 +1,53 @@
+const { checkChunkModules } = require("@rspack/test-tools");
+
+module.exports = {
+	checkStats(stepName, stats) {
+		switch (stepName) {
+			case '0':
+				checkChunkModules(stats, {
+					'dyn-1': [
+						'dyn-1.js',
+						'm.js',
+					],
+					shared: [
+						'shared.js',
+					]
+				})
+				break
+			case '1':
+				checkChunkModules(stats, {
+					'dyn-1': [
+						'dyn-1.js',
+						'm.js'
+					],
+					'dyn-2': [
+						'dyn-2.js',
+					],
+					shared: [
+						'shared.js',
+						'm.js'
+					]
+				})
+				break;
+			case '2':
+				checkChunkModules(stats, {
+					'dyn-1': [
+						'dyn-1.js',
+						'm.js'
+					],
+					'dyn-2': [
+						'dyn-2.js',
+						'm.js'
+					],
+					shared: [
+						'shared.js',
+					]
+				})
+				break;
+			default:
+				throw "no have more step"
+		}
+
+		return true
+	}
+}

packages/rspack-test-tools/tests/watchCases/split-chunks-incremental/chunk-modify/0/index.js

@@ -1,24 +1,8 @@
-const { checkChunkModules } = __non_webpack_require__("@rspack/test-tools");
-
 it('should compile', async () => {
 	const [v1, v2] = await Promise.all([
 		import('./dyn-1').then(m => m.default),
 		import('./dyn-2').then(m => m.default)
 	])
 	expect(v1.default).toBe('shared')
 	expect(v2.default).toBe('shared')
-
-	checkChunkModules(STATS_JSON, {
-		'dyn-1': [
-			'dyn-1.js',
-			'm.js'
-		],
-		'dyn-2': [
-			'dyn-2.js',
-		],
-		shared: [
-			'shared.js',
-			'm.js',
-		]
-	})
 })

packages/rspack-test-tools/tests/watchCases/split-chunks-incremental/chunk-modify/1/index.js

@@ -1,16 +1,4 @@
-const { checkChunkModules } = __non_webpack_require__("@rspack/test-tools");
-
 it('should compile', async () => {
 	const v1 = await import('./dyn-1').then(m => m.default)
 	expect(v1.default).toBe('shared')
-
-	checkChunkModules(STATS_JSON, {
-		'dyn-1': [
-			'dyn-1.js',
-			'm.js'
-		],
-		shared: [
-			'shared.js',
-		]
-	})
 })

packages/rspack-test-tools/tests/watchCases/split-chunks-incremental/chunk-modify/2/index.js

@@ -1,24 +1,8 @@
-const { checkChunkModules } = __non_webpack_require__("@rspack/test-tools");
-
 it('should compile', async () => {
 	const [v1, v2] = await Promise.all([
 		import('./dyn-1').then(m => m.default),
 		import('./dyn-2').then(m => m.default)
 	])
 	expect(v1.default).toBe('shared')
 	expect(v2.default).toBe('shared')
-
-	checkChunkModules(STATS_JSON, {
-		'dyn-1': [
-			'dyn-1.js',
-			'm.js'
-		],
-		'dyn-2': [
-			'dyn-2.js',
-			'm.js'
-		],
-		shared: [
-			'shared.js',
-		]
-	})
 })