Skip to content

Commit

Permalink
test: create issues for failed webpack test
Browse files Browse the repository at this point in the history
- remove test.filter.js for passed webpack test
- create issues for failed webpack test
  • Loading branch information
GiveMe-A-Name committed Dec 4, 2024
1 parent 8cb46c9 commit 6eb4a65
Show file tree
Hide file tree
Showing 15 changed files with 22 additions and 25 deletions.
Original file line number Diff line number Diff line change
@@ -1,2 +1 @@
// TODO: Should create a issue for this test
module.exports = () => { return false }
module.exports = () => { return 'https://github.com/web-infra-dev/rspack/issues/7822' }
Original file line number Diff line number Diff line change
@@ -1,2 +1 @@
// TODO: Should create a issue for this test
module.exports = () => { return false }
module.exports = () => { return 'https://github.com/web-infra-dev/rspack/issues/8603' }
Original file line number Diff line number Diff line change
@@ -1,2 +1 @@
// TODO: Should create a issue for this test
module.exports = () => { return false }
module.exports = () => { return 'https://github.com/web-infra-dev/rspack/issues/7822' }
Original file line number Diff line number Diff line change
@@ -1,2 +1,3 @@
// TODO: Should create a issue for this test
// `optimization.moduleIds = "hashed"` is deprecated in webpack.
// So we do not have to implement in Rspack.
module.exports = () => { return false }
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
"use strict";
it("should include only one use strict per module", function() {
it("should include only one use strict per module", function () {
require("./harmony-with-strict");
require("./harmony-without-strict");
require("./harmony-with-strict2");
Expand All @@ -17,5 +17,12 @@ it("should include only one use strict per module", function() {

matches.sort();

expect(matches).toEqual(["/******/ var __webpack_modules__ = ({"]);
// expect(matches).toEqual(["/******/ var __webpack_modules__ = ({"]);
// In Rspack, the output is: `var __webpack_modules__ = ({`
// In webpack, the output is: `/******/ var __webpack_modules__ = ({`
//
// It is only output format difference between Rspack and webpack.

expect(matches).toEqual(["var __webpack_modules__ = ({"]);

});

This file was deleted.

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -20,5 +20,5 @@ module.exports = {
}
}
}
}
},
};
Original file line number Diff line number Diff line change
@@ -1,3 +1,2 @@
// blocked by https://github.com/web-infra-dev/rspack/issues/3465
// TODO: Should create a issue for this test
module.exports = () => { return false }
module.exports = () => { return 'https://github.com/web-infra-dev/rspack/issues/8604' }
Original file line number Diff line number Diff line change
Expand Up @@ -109,9 +109,7 @@ module.exports = [
type: "asset/resource",
generator: {
// should result in same hash as bundle2
// TODO: function type is not supported for now
// publicPath: () => "/public/"
publicPath: "/public/"
publicPath: () => "/public/"
}
}
]
Expand Down
Original file line number Diff line number Diff line change
@@ -1,3 +1,2 @@
// blocked by chunkIds
// TODO: Should create a issue for this test
module.exports = () => { return false }
module.exports = () => { return 'https://github.com/web-infra-dev/rspack/issues/8605' }
Original file line number Diff line number Diff line change
@@ -1,2 +1,3 @@
// TODO: Should create a issue for this test
// rspack don't have ContextExclusionPlugin.
// skip it, because ContextExclusionPlugin already instead of IgnorePlugin.
module.exports = () => { return false }

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

This file was deleted.

Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
// TODO: Should create a issue for this test
module.exports = () => { return false }
module.exports = () => { return true }

0 comments on commit 6eb4a65

Please sign in to comment.